[3/3] kudu git commit: [client] add WARN_UNUSED_RESULT for a few static functions

[al...@apache.org]

[client] add WARN_UNUSED_RESULT for a few static functions

This patch adds the WARN_UNUSED_RESULT attribute for the following
static functions in the kudu::client namespace:

  * SetInternalSignalNumber(int signum)
  * DisableSaslInitialization()
  * DisableOpenSSLInitialization()

This change does not affect the exported symbols of the above mentioned
functions in the kudu_client library, so this change is
backward-compatible.

Change-Id: Id66cad549ebf57e94da2d8a7cbc85b5476fa168d
Reviewed-on: http://gerrit.cloudera.org:8080/12090
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/ce52b150
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/ce52b150
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/ce52b150

Branch: refs/heads/master
Commit: ce52b150e8a8879c9ef2ec577c0e6665d75539a6
Parents: 9be2911
Author: Alexey Serbin <al...@apache.org>
Authored: Fri Dec 14 10:09:50 2018 -0800
Committer: Alexey Serbin <as...@cloudera.com>
Committed: Fri Dec 14 21:00:07 2018 +0000

----------------------------------------------------------------------
 src/kudu/client/client.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/ce52b150/src/kudu/client/client.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h
index 626df7d..f8a9fc1 100644
--- a/src/kudu/client/client.h
+++ b/src/kudu/client/client.h
@@ -144,7 +144,7 @@ void KUDU_EXPORT SetVerboseLogLevel(int level);
 /// @param [in] signum
 ///   Signal number to use for internal.
 /// @return Operation result status.
-Status KUDU_EXPORT SetInternalSignalNumber(int signum);
+Status KUDU_EXPORT SetInternalSignalNumber(int signum) WARN_UNUSED_RESULT;
 
 /// Disable initialization of the Cyrus SASL library. Clients should call this
 /// method before using the Kudu client if they are manually initializing Cyrus
@@ -157,7 +157,7 @@ Status KUDU_EXPORT SetInternalSignalNumber(int signum);
 /// NOTE: Kudu makes use of SASL from multiple threads. Thus, it's imperative
 /// that embedding applications use sasl_set_mutex(3) to provide a mutex
 /// implementation if they are choosing to handle SASL initialization manually.
-Status KUDU_EXPORT DisableSaslInitialization();
+Status KUDU_EXPORT DisableSaslInitialization() WARN_UNUSED_RESULT;
 
 
 /// Disable initialization of the OpenSSL library. Clients should call this
@@ -182,7 +182,7 @@ Status KUDU_EXPORT DisableSaslInitialization();
 ///   RAND_poll(); // or an equivalent RAND setup.
 ///   CRYPTO_set_locking_callback(MyAppLockingCallback);
 /// @endcode
-Status KUDU_EXPORT DisableOpenSSLInitialization();
+Status KUDU_EXPORT DisableOpenSSLInitialization() WARN_UNUSED_RESULT;
 
 /// @return Short version info, i.e. a single-line version string
 ///   identifying the Kudu client.