[GitHub] [hive] belugabehr commented on a change in pull request #1118: HIVE-23363: Upgrade DataNucleus dependency to 5.2

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #1118:
URL: https://github.com/apache/hive/pull/1118#discussion_r448558398



##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -345,20 +345,20 @@
       <datastore-identity>
         <column name="CD_ID"/>
       </datastore-identity>
-      <field name="cols" table="COLUMNS_V2" >
+      <field name="cols" persistence-modifier="persistent" table="COLUMNS_V2">
         <collection element-type="MFieldSchema"/>
-        <foreign-key name="COLUMNS_V2_FK" delete-action="cascade"/>

Review comment:
       ```
   If a foreign-key is specified (in MetaData) for the relation field then leave any deletion to the datastore to perform
   ``` 
   I don't see any such relationship cascading relationship defined in the schema for Derby or MySQL, so DN should be doing it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org