[GitHub] matthiasblaesing commented on a change in pull request #888: [NETBEANS-1074] Module review j2ee.beanvalidation

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #888: [NETBEANS-1074] Module review j2ee.beanvalidation
URL: https://github.com/apache/incubator-netbeans/pull/888#discussion_r219706074
 
 

 ##########
 File path: enterprise/javaee.beanvalidation/build.xml
 ##########
 @@ -23,8 +23,6 @@
     <description>Builds, tests, and runs the project org.netbeans.modules.javaee.beanvalidation</description>
     <import file="../../nbbuild/templates/projectized.xml"/>
 
-    <property name="resources.dir" value="./src/org/netbeans/modules/javaee/beanvalidation/resources/"/>
     <target name="build-init" depends="projectized.build-init">
-        <unzip src="external/javaee.beanvalidation-resources.zip" dest="${resources.dir}"/>
     </target>
 
 Review comment:
   Sorry - I missed this in the first round - lines 26 + 27 can be removed to. The qualified call to the imported target is only needed if the target is overriden. With that change this should be good. The build failure is caused by hg.netbeans.org being not reachable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists