You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/02/28 20:21:55 UTC
[GitHub] storm pull request #1980: Storm-2104 1.0.x
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/1980
Storm-2104 1.0.x
Putting https://github.com/apache/storm/pull/1818 on 1.0.x as well since @qiozas asked about it here https://github.com/apache/storm/pull/1696
Only change from 1.x version is that `KafkaSpout.emitTupleIfNotEmitted` returns void instead of boolean here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2104-1.0.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1980.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1980
----
commit 9f902722551215d53297ddabcff174477b814c57
Author: Stig Rohde D�ssing <st...@gmail.com>
Date: 2016-09-20T11:53:55Z
STORM-2104: More graceful handling of acked/failed tuples after partition reassignment in new Kafka spout
commit b649f093fe67dc5eb1e39c191bd6671e6606572a
Author: Stig Rohde D�ssing <sd...@it-minds.dk>
Date: 2016-12-08T18:34:07Z
STORM-2104: Rewrite a few parts to be compatible with Java 7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1980: Storm-2104 1.0.x
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1980#discussion_r105031710
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java ---
@@ -164,15 +164,15 @@ public Builder(Map<String, Object> kafkaProps, KafkaSpoutStreams kafkaSpoutStrea
/**
* Specifying this key deserializer overrides the property key.deserializer
*/
- public Builder<K,V> setKeyDeserializer(Deserializer<K> keyDeserializer) {
+ public Builder<K,V> setKeyDeserializer(SerializableDeserializer<K> keyDeserializer) {
--- End diff --
It doesn't. I'll revert this part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1980: Storm-2104 1.0.x
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1980
Thanks for the quick fix. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1980: Storm-2104 1.0.x
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1980#discussion_r105030392
--- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java ---
@@ -164,15 +164,15 @@ public Builder(Map<String, Object> kafkaProps, KafkaSpoutStreams kafkaSpoutStrea
/**
* Specifying this key deserializer overrides the property key.deserializer
*/
- public Builder<K,V> setKeyDeserializer(Deserializer<K> keyDeserializer) {
+ public Builder<K,V> setKeyDeserializer(SerializableDeserializer<K> keyDeserializer) {
--- End diff --
I'm not 100% sure it keeps binary compatibility. `Serializable ` doesn't have methods so it might work, but just not sure.
Once who makes me clear that this is also safe for binary compatibility, I'll give +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1980: Storm-2104 1.0.x
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1980
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---