[GitHub] [kafka] cadonna commented on a diff in pull request #13127: Kafka 14586: Moving StreamResetter to tools

[GitBox <gi...@apache.org>]

cadonna commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081000404


##########
build.gradle:
##########
@@ -1757,6 +1757,7 @@ project(':tools') {
   archivesBaseName = "kafka-tools"
 
   dependencies {
+    implementation project(':core')

Review Comment:
   Ticket https://issues.apache.org/jira/browse/KAFKA-14525 (the parent of https://issues.apache.org/jira/browse/KAFKA-14586) says 
   
   > tools that don't require access to `core` classes and communicate via the kafka protocol (typically by using the client classes) should be moved to the `tools` module.
   
   This addition contradicts that requirement.
   
   As far as I see, `kafka.utils.CommandLineUtils` is the only dependency to `core`. Is that true? Would it be possible to move `kafka.utils.CommandLineUtils` to a different module? Or should we even get completely rid of that dependency by rewriting it in java and put it in a different module.
   
   https://issues.apache.org/jira/browse/KAFKA-14576 should have a similar issue since also the console consumer should be moved to tools and it has a dependency to  `kafka.utils.CommandLineUtils`.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org