[GitHub] [hadoop] aw-was-here commented on issue #539: HADOOP-16109. Parquet reading S3AFileSystem causes EOF

[GitBox <gi...@apache.org>]

aw-was-here commented on issue #539: HADOOP-16109. Parquet reading S3AFileSystem causes EOF
URL: https://github.com/apache/hadoop/pull/539#issuecomment-470348002
 
 
   TL;DR: squash and rebase regularly
   
   > does Yetus perhaps try to test each commit individually? ... [Later Edit] It looks like maybe a GitHub issue.
   
   Yup.
   
   Yetus gets the equivalent of 'git format-patch' and then calls 'git apply'  or 'patch' or whatever works on top of master (or branch-2 or whatever) with it. This has several downsides, but most of them go away if the patch branch is regularly rebased and commits are squashed.  The latter fixes 99% of the issues.  When commits aren't squashed, you'll see weird stuff like what shows up here.  (Remember, the top of the other tree is moving too....)
   
   It's important to note that git/github really only provides three ways to handle PRs:
   * git merge
   * git diff
   * git format-patch
   
   The first one has lots of issues from a Yetus functionality perspective since it taints the source tree and doing multiple checkouts has other issues (remember: yetus also runs locally!). The second one doesn't work with binary files.  That leaves us with the third one, which has lots of weird idiosyncracies but works when good branch hygiene is in play.  YETUS-724 will enable test-patch to switch to using the git diff IFF the format-patch version of the file can't be applied.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org