You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2008/11/11 16:58:44 UTC

[jira] Created: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Enhance the snappull command in ReplicationHandler to take in masterUrl
-----------------------------------------------------------------------

                 Key: SOLR-847
                 URL: https://issues.apache.org/jira/browse/SOLR-847
             Project: Solr
          Issue Type: Improvement
            Reporter: Noble Paul
            Priority: Minor
             Fix For: 1.4


It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-847.
----------------------------------------

    Resolution: Fixed

Committed revision 729263.

Thanks Noble and Preetam!

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-847:
---------------------------------------

    Attachment: SOLR-847.patch

Adding a solrconfig.xml with an empty replication handler section for the test.

I plan to commit shortly.

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658922#action_12658922 ] 

Noble Paul commented on SOLR-847:
---------------------------------

It would be better to think of security outside of the handler. 



> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658918#action_12658918 ] 

Shalin Shekhar Mangar commented on SOLR-847:
--------------------------------------------

Shouldn't we have a way to disable arbitary replication, maybe as a default?

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-847:
----------------------------

    Attachment: SOLR-847.patch

take in an extra parameter while triggerring snappull

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658925#action_12658925 ] 

Shalin Shekhar Mangar commented on SOLR-847:
--------------------------------------------

Perhaps we can configure Solr to disable requests to any URL in a given list of URLs? Or did you mean outside Solr itself?

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-847:
----------------------------

    Attachment: SOLR-847.patch

the testcase works now

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar reassigned SOLR-847:
------------------------------------------

    Assignee: Shalin Shekhar Mangar

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659037#action_12659037 ] 

Noble Paul commented on SOLR-847:
---------------------------------

Access control  common requirement . We must think of moving that to the RequestHandlerBase and provide a common syntax for allow/disallow requests . 



> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-847:
---------------------------------------

    Component/s: replication (java)

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Preetam Rao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Preetam Rao updated SOLR-847:
-----------------------------

    Attachment: SOLR-847.patch

- Added Two test cases in TestReplicationHandler.
1) test for disable polling
2) test for adding masterUrl parameter to snap pull command. This test case fails. Needs fixing.

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659071#action_12659071 ] 

Shalin Shekhar Mangar commented on SOLR-847:
--------------------------------------------

I just committed another change. Remove 'pollInterval' if it exists in the request parameters because this command is intended to do a snappull only once from the specified masterUrl. Otherwise an executor service is started which does snallpull according to given period.

Committed revision 729282.

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-847:
----------------------------

    Attachment: SOLR-847.patch

updated w/ trunk

> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SOLR-847) Enhance the snappull command in ReplicationHandler to take in masterUrl

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659037#action_12659037 ] 

noble.paul edited comment on SOLR-847 at 12/23/08 8:31 PM:
-----------------------------------------------------------

Access control is a common requirement . We must think of moving that to the RequestHandlerBase and provide a common syntax for allow/disallow requests . 



      was (Author: noble.paul):
    Access control  common requirement . We must think of moving that to the RequestHandlerBase and provide a common syntax for allow/disallow requests . 


  
> Enhance the snappull command in ReplicationHandler to take in masterUrl
> -----------------------------------------------------------------------
>
>                 Key: SOLR-847
>                 URL: https://issues.apache.org/jira/browse/SOLR-847
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication (java)
>            Reporter: Noble Paul
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-847.patch, SOLR-847.patch, SOLR-847.patch, SOLR-847.patch
>
>
> It should be possible to pass in the masterUrl as a parameter to snappull command so that we can replicate data from arbitrary master

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.