You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/03 14:17:18 UTC

[GitHub] [flink] fapaul commented on a change in pull request #16676: [FLINK-22902] Port KafkaSink to FLIP-143

fapaul commented on a change in pull request #16676:
URL: https://github.com/apache/flink/pull/16676#discussion_r681803300



##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -78,6 +78,18 @@ under the License.
 			<version>${kafka.version}</version>
 		</dependency>
 
+		<dependency>
+			<groupId>org.apache.kafka</groupId>
+			<artifactId>kafka_${scala.binary.version}</artifactId>
+			<version>${kafka.version}</version>
+			<exclusions>

Review comment:
       Unfortunately, I can't exclude all transitive dependencies because the old tests are instantiating a KafkaServer. We can either think of moving the KafkaSink to a different module or keep it as is until we remove all the old tests and can properly exclude the transitive dependencies.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org