You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/13 15:54:35 UTC
Review Request 70206: Displayed error message on resource validation
failures.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
When pushing a reservation, the validation code would not
print the error that caused validation to fail. This could
result in developers scratching their heads in confusion.
Diffs
-----
src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f
Diff: https://reviews.apache.org/r/70206/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70206: Displayed error message on resource
validation failures.
Posted by Benno Evers <be...@mesosphere.com>.
> On March 19, 2019, 1:48 p.m., Benjamin Bannier wrote:
> > src/v1/resources.cpp
> > Line 1731 (original), 1731-1733 (patched)
> > <https://reviews.apache.org/r/70206/diff/1/?file=2132246#file2132246line1731>
> >
> > Let's separate this block by newlines.
Fixed this while merging.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213805
-----------------------------------------------------------
On March 13, 2019, 3:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 3:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
>
>
> Diffs
> -----
>
> src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f
>
>
> Diff: https://reviews.apache.org/r/70206/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70206: Displayed error message on resource
validation failures.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213805
-----------------------------------------------------------
Fix it, then Ship it!
Finally! I cannot count the number of times I manually patched this into the code when debugging :D
src/v1/resources.cpp
Line 1731 (original), 1731-1733 (patched)
<https://reviews.apache.org/r/70206/#comment299833>
Let's separate this block by newlines.
- Benjamin Bannier
On March 13, 2019, 4:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
>
>
> Diffs
> -----
>
> src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f
>
>
> Diff: https://reviews.apache.org/r/70206/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70206: Displayed error message on resource
validation failures.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213670
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70206]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 13, 2019, 3:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 3:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
>
>
> Diffs
> -----
>
> src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f
>
>
> Diff: https://reviews.apache.org/r/70206/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70206: Displayed error message on resource
validation failures.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70206/#review213711
-----------------------------------------------------------
PASS: Mesos patch 70206 was successfully built and tested.
Reviews applied: `['70206']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2954/mesos-review-70206
- Mesos Reviewbot Windows
On March 13, 2019, 3:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70206/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 3:54 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When pushing a reservation, the validation code would not
> print the error that caused validation to fail. This could
> result in developers scratching their heads in confusion.
>
>
> Diffs
> -----
>
> src/v1/resources.cpp 110be1057b7b5cc256787a22f113fc81f94edc9f
>
>
> Diff: https://reviews.apache.org/r/70206/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>