[commons-collections] branch master updated: COLLECTIONS-836: fix flaky test DualHashBidiMapTest (#353)

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git


The following commit(s) were added to refs/heads/master by this push:
     new 14d7d98e7 COLLECTIONS-836: fix flaky test DualHashBidiMapTest (#353)
14d7d98e7 is described below

commit 14d7d98e7e3c993ac2e0f8b32ccc3789eb7ecc14
Author: anantdahiya8 <th...@gmail.com>
AuthorDate: Sat Nov 5 02:50:37 2022 -0500

    COLLECTIONS-836: fix flaky test DualHashBidiMapTest (#353)
---
 .../org/apache/commons/collections4/bidimap/AbstractBidiMapTest.java  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/test/java/org/apache/commons/collections4/bidimap/AbstractBidiMapTest.java b/src/test/java/org/apache/commons/collections4/bidimap/AbstractBidiMapTest.java
index 8a9a0b653..e4b16a8a7 100644
--- a/src/test/java/org/apache/commons/collections4/bidimap/AbstractBidiMapTest.java
+++ b/src/test/java/org/apache/commons/collections4/bidimap/AbstractBidiMapTest.java
@@ -27,8 +27,10 @@ import java.util.Set;
 import org.apache.commons.collections4.BidiMap;
 import org.apache.commons.collections4.BulkTest;
 import org.apache.commons.collections4.MapIterator;
+import org.apache.commons.collections4.collection.AbstractCollectionTest;
 import org.apache.commons.collections4.iterators.AbstractMapIteratorTest;
 import org.apache.commons.collections4.map.AbstractIterableMapTest;
+import org.junit.jupiter.api.Assumptions;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -265,6 +267,8 @@ public abstract class AbstractBidiMapTest<K, V> extends AbstractIterableMapTest<
 
     @Test
     public void testBidiKeySetValuesOrder() {
+        // Skip if collection is unordered
+        Assumptions.assumeFalse((getIterationBehaviour() & AbstractCollectionTest.UNORDERED) != 0);
         resetFull();
         final Iterator<K> keys = map.keySet().iterator();
         final Iterator<V> values = map.values().iterator();