[GitHub] [superset] michael-s-molina commented on a change in pull request #18926: fix(explore comma): make that the comma can be added by removing it from token separators…

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #18926:
URL: https://github.com/apache/superset/pull/18926#discussion_r821697809



##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -266,35 +267,33 @@ const getQueryCacheKey = (value: string, page: number, pageSize: number) =>
  * Each of the categories come with different abilities. For a comprehensive guide please refer to
  * the storybook in src/components/Select/Select.stories.tsx.
  */
-const Select = (
-  {
-    allowNewOptions = false,
-    ariaLabel,
-    fetchOnlyOnSearch,
-    filterOption = true,
-    header = null,
-    invertSelection = false,
-    labelInValue = false,
-    lazyLoading = true,
-    loading,
-    mode = 'single',
-    name,
-    notFoundContent,
-    onError,
-    onChange,
-    onClear,
-    onDropdownVisibleChange,
-    optionFilterProps = ['label', 'value'],
-    options,
-    pageSize = DEFAULT_PAGE_SIZE,
-    placeholder = t('Select ...'),
-    showSearch = true,
-    sortComparator = defaultSortComparator,
-    value,
-    ...props
-  }: SelectProps,
-  ref: RefObject<HTMLInputElement>,
-) => {
+const Select = ({
+  allowNewOptions = false,
+  ariaLabel,
+  fetchOnlyOnSearch,
+  filterOption = true,
+  header = null,
+  invertSelection = false,
+  labelInValue = false,
+  lazyLoading = true,
+  loading,
+  mode = 'single',
+  name,
+  notFoundContent,
+  onError,
+  onChange,
+  onClear,
+  optionFilterProps = ['label', 'value'],
+  options,
+  pageSize = DEFAULT_PAGE_SIZE,
+  placeholder = t('Select ...'),
+  showSearch = true,
+  sortComparator = defaultSortComparator,
+  tokenSeparators,
+  value,
+  ...props
+}: SelectProps,
+ref: RefObject<HTMLInputElement>,) => {

Review comment:
       ```suggestion
   ref: RefObject<HTMLInputElement>) => {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org