You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rainer Jung <ra...@kippdata.de> on 2017/10/16 13:30:25 UTC
Re: buildbot failure in on httpd-trunk
Am 16.10.2017 um 11:23 schrieb buildbot@apache.org:
> The Buildbot has detected a new failure on builder httpd-trunk while building . Full details are available at:
> https://ci.apache.org/builders/httpd-trunk/builds/1199
>
> Buildbot URL: https://ci.apache.org/
>
> Buildslave for this Build: bb_slave6_ubuntu
>
> Build Reason: The AnyBranchScheduler scheduler named 'httpd-trunk-on-commit' triggered this build
> Build Source Stamp: [branch httpd/httpd/trunk] 1812263
> Blamelist: rjung
>
> BUILD FAILED: failed compile
The failure is
In file included from
/home/buildslave/slave/httpd-trunk/build/include/ap_config.h:184:0,
from
/home/buildslave/slave/httpd-trunk/build/include/httpd.h:44,
from util_expr_private.h:20,
from util_expr_parse.y:32:
/home/buildslave/slave/httpd-trunk/build/include/ap_config_auto.h:357:16:
error: two or more data types in declaration specifiers
#define rlim_t int
^
/home/buildslave/slave/httpd-trunk/build/build/rules.mk:207: recipe for
target 'util_expr_parse.lo' failed
which showed up, because now we actually run maintainer mode with -Werror.
Does anybody know hot e can look at the contantes of
server/util_expr_parse.c in the buildbot build dir?
Regards,
Rainer
Re: buildbot failure in on httpd-trunk
Posted by Rainer Jung <ra...@kippdata.de>.
Am 17.10.2017 um 02:19 schrieb Yann Ylavic:
> On Tue, Oct 17, 2017 at 1:23 AM, Yann Ylavic <yl...@gmail.com> wrote:
>> On Tue, Oct 17, 2017 at 12:48 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
>>> Rainer,
>>>
>>> https://ci.apache.org/builders/httpd-trunk/builds/1203
>>>
>>> would you please re-kick this build from a clean svn checkout? I think we have
>>> various mistakes in our exports.c preprocessor that become tangled in any
>>> rebuild scenario.
>>
>> Hmm, not sure, looks like an issue with the "inline" keyword used in
>> some system (systemd) header file, and c89.
>> According to github, systemd's master branch uses __inline__ there
>> instead (which should be fine with gcc's c89), so dunno if we can do
>> something like this (when -stdc=c89):
>>
>> #undef inline
>> #define inline __inline__ /* or APR_INLINE? */
>> #include <sd-journal.h>
>>
>> Nor if it can even work to #undef "inline"...
>
> Looks fixed now: https://ci.apache.org/builders/httpd-trunk/builds/1205
Thanks Yann for fixing.
For those who didn't follow that closely: we now fixed the maintainer
build (which eg. is used by buildbot) to actually use the gcc flags that
we expected. All of the flags are tested for gcc supporting them before
adding them and those tests partially failed not due to gcc not
supporting them but due to the tests generating warnings and due to
-Werror actually failing.
Now that we have fixed maintainer mode, builds can fail due to new build
errors, that previously only showed up as warnings. The above is one
such case and Joe, Yann and me fixed at least three such cases in trunk.
Currently it looks like the build is fine, but depending on your
dependency libraries and the set of modules you build there's still a
little risk, that you might observe new failures.
Regards,
Rainer
Re: buildbot failure in on httpd-trunk
Posted by Yann Ylavic <yl...@gmail.com>.
On Tue, Oct 17, 2017 at 1:23 AM, Yann Ylavic <yl...@gmail.com> wrote:
> On Tue, Oct 17, 2017 at 12:48 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
>> Rainer,
>>
>> https://ci.apache.org/builders/httpd-trunk/builds/1203
>>
>> would you please re-kick this build from a clean svn checkout? I think we have
>> various mistakes in our exports.c preprocessor that become tangled in any
>> rebuild scenario.
>
> Hmm, not sure, looks like an issue with the "inline" keyword used in
> some system (systemd) header file, and c89.
> According to github, systemd's master branch uses __inline__ there
> instead (which should be fine with gcc's c89), so dunno if we can do
> something like this (when -stdc=c89):
>
> #undef inline
> #define inline __inline__ /* or APR_INLINE? */
> #include <sd-journal.h>
>
> Nor if it can even work to #undef "inline"...
Looks fixed now: https://ci.apache.org/builders/httpd-trunk/builds/1205
Re: buildbot failure in on httpd-trunk
Posted by Yann Ylavic <yl...@gmail.com>.
On Tue, Oct 17, 2017 at 12:48 AM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
> Rainer,
>
> https://ci.apache.org/builders/httpd-trunk/builds/1203
>
> would you please re-kick this build from a clean svn checkout? I think we have
> various mistakes in our exports.c preprocessor that become tangled in any
> rebuild scenario.
Hmm, not sure, looks like an issue with the "inline" keyword used in
some system (systemd) header file, and c89.
According to github, systemd's master branch uses __inline__ there
instead (which should be fine with gcc's c89), so dunno if we can do
something like this (when -stdc=c89):
#undef inline
#define inline __inline__ /* or APR_INLINE? */
#include <sd-journal.h>
Nor if it can even work to #undef "inline"...
Re: buildbot failure in on httpd-trunk
Posted by William A Rowe Jr <wr...@rowe-clan.net>.
Rainer,
https://ci.apache.org/builders/httpd-trunk/builds/1203
would you please re-kick this build from a clean svn checkout? I think we have
various mistakes in our exports.c preprocessor that become tangled in any
rebuild scenario.
On Mon, Oct 16, 2017 at 8:30 AM, Rainer Jung <ra...@kippdata.de> wrote:
> Am 16.10.2017 um 11:23 schrieb buildbot@apache.org:
>>
>> The Buildbot has detected a new failure on builder httpd-trunk while
>> building . Full details are available at:
>> https://ci.apache.org/builders/httpd-trunk/builds/1199
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: bb_slave6_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named
>> 'httpd-trunk-on-commit' triggered this build
>> Build Source Stamp: [branch httpd/httpd/trunk] 1812263
>> Blamelist: rjung
>>
>> BUILD FAILED: failed compile
>
>
> The failure is
>
> In file included from
> /home/buildslave/slave/httpd-trunk/build/include/ap_config.h:184:0,
> from
> /home/buildslave/slave/httpd-trunk/build/include/httpd.h:44,
> from util_expr_private.h:20,
> from util_expr_parse.y:32:
> /home/buildslave/slave/httpd-trunk/build/include/ap_config_auto.h:357:16:
> error: two or more data types in declaration specifiers
> #define rlim_t int
> ^
> /home/buildslave/slave/httpd-trunk/build/build/rules.mk:207: recipe for
> target 'util_expr_parse.lo' failed
>
> which showed up, because now we actually run maintainer mode with -Werror.
>
> Does anybody know hot e can look at the contantes of
> server/util_expr_parse.c in the buildbot build dir?
>
> Regards,
>
> Rainer
>
Re: buildbot failure in on httpd-trunk
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Oct 16, 2017 at 3:30 PM, Rainer Jung <ra...@kippdata.de> wrote:
> Am 16.10.2017 um 11:23 schrieb buildbot@apache.org:
>>
>> The Buildbot has detected a new failure on builder httpd-trunk while
>> building . Full details are available at:
>> https://ci.apache.org/builders/httpd-trunk/builds/1199
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: bb_slave6_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named
>> 'httpd-trunk-on-commit' triggered this build
>> Build Source Stamp: [branch httpd/httpd/trunk] 1812263
>> Blamelist: rjung
>>
>> BUILD FAILED: failed compile
>
>
> The failure is
>
> In file included from
> /home/buildslave/slave/httpd-trunk/build/include/ap_config.h:184:0,
> from
> /home/buildslave/slave/httpd-trunk/build/include/httpd.h:44,
> from util_expr_private.h:20,
> from util_expr_parse.y:32:
> /home/buildslave/slave/httpd-trunk/build/include/ap_config_auto.h:357:16:
> error: two or more data types in declaration specifiers
> #define rlim_t int
> ^
> /home/buildslave/slave/httpd-trunk/build/build/rules.mk:207: recipe for
> target 'util_expr_parse.lo' failed
>
> which showed up, because now we actually run maintainer mode with -Werror.
Same error here:
configure:30308: checking for rlim_t
configure:30329: gcc -c -g -O0 -fno-strict-aliasing -Wall
-Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations
-pthread -Wpointer-arith -Wno-error=strict-prototypes -std=c89 -Werror
-Wdeclaration-after-statement -Wformat -Wformat-security -Wunused
-DLINUX -D_REENTRANT -D_GNU_SOURCE -DAP_DEBUG conftest.c >&5
conftest.c:59:1: warning: function declaration isn't a prototype
[-Wstrict-prototypes]
main ()
^~~~
conftest.c: In function 'main':
conftest.c:61:8: error: unused variable 'spoon' [-Werror=unused-variable]
rlim_t spoon;
^~~~~
cc1: all warnings being treated as errors
configure:30329: $? = 1
So it's starting to be a lot of warnings we'd have -Wno-error in
CFLAGS, Joe's proposal looks better (not really working for me either
for now, but let's discuss it in the other thread).
>
> Does anybody know hot e can look at the contantes of
> server/util_expr_parse.c in the buildbot build dir?
I don't think it's particularly related to ap_expr code (see error
above), it's just that yacc may be using rlim_t somewhere...
Regards,
Yann.