[jira] [Commented] (SPARK-3849) Automate remaining Spark Code Style Guide rules

["Matei Zaharia (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168961#comment-14168961 ] 

Matei Zaharia commented on SPARK-3849:
--------------------------------------

Just to comment the same thing I did on the mailing list -- I'm against adding such changes if they require a large sweep through all the files in the project. That slows down development for everyone who has a waiting patch and makes backporting patches to old versions of Spark much harder. This is simply not worth the slight improvement in code style (the code style is actually pretty consistent as is). If you find a way to make it apply only to new code when Jenkins tests it, that would be fine.

> Automate remaining Spark Code Style Guide rules
> -----------------------------------------------
>
>                 Key: SPARK-3849
>                 URL: https://issues.apache.org/jira/browse/SPARK-3849
>             Project: Spark
>          Issue Type: Improvement
>          Components: Project Infra
>            Reporter: Nicholas Chammas
>
> Style problems continue to take up a large amount of review time, mostly because there are many [Spark Code Style Guide|https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide] rules that have not been automated.
> This issue tracks the remaining rules that have not automated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org