You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/02/20 20:43:45 UTC
[GitHub] [incubator-datasketches-cpp] steveatwork opened a new issue #93:
Installation error
steveatwork opened a new issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93
Trying all the different approaches to installation but they all seem to boil down to this error:
`incubator-datasketches-cpp/python/src/fi_wrapper.cpp:90:6: error: no matching member function for call to 'def'
.def("merge", &frequent_items_sketch<T>::merge)`
along with a few other errors in pybind of `candidate template ignored`
What am I missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin commented on issue #93:
Installation error
Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93#issuecomment-589324834
We added a moving merge method earlier but we don't have a CI pipeline to run the full set of tests and missed that.
Pybind is confused about which merge method to use, so need to specify one in that line. I believe that will fix it. I dunno how fast I can get an approval on the patch but I _think_ i can get a new branch in a few minutes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov closed issue #93:
Installation error
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov closed issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] steveatwork commented on issue #93:
Installation error
Posted by GitBox <gi...@apache.org>.
steveatwork commented on issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93#issuecomment-589337958
Thanks for the speedy response and fix! I really imagined that I had something misconfigured on my end because... that's usually what the trouble is.
While I'm here I also wanted to point out that in the recursive clone the pybind repo is linked with ssh which can cause a sad permission error for anyone not set up for ssh. Https links for that dependency would make it simpler, since it's a public package anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin commented on issue #93:
Installation error
Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93#issuecomment-589548116
@steveatwork thanks for that suggestion.
I have a branch pybind_via_https that supposedly changes the include to https. It works if I look at the .gitmodules file, anyway. But I made it a clean branch -- which means the earlier fix isn't in it since that hasn't been merged yet (pending review). I think/hope it'll all be tidied up sometime Friday, US Pacific time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] steveatwork commented on issue #93:
Installation error
Posted by GitBox <gi...@apache.org>.
steveatwork commented on issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93#issuecomment-589798473
Tested and everything looks fine to me. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov commented on issue
#93: Installation error
Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93#issuecomment-589786575
@steveatwork The fix is in the master. Could you give it a go please? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [incubator-datasketches-cpp] jmalkin commented on issue #93:
Installation error
Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #93: Installation error
URL: https://github.com/apache/incubator-datasketches-cpp/issues/93#issuecomment-589331887
Yup, a one-line fix. Change that line to:
`.def("merge", (void (frequent_items_sketch<T>::*)(const frequent_items_sketch<T>&)) &frequent_items_sketch<T>::merge)`
and it should work. Alternatively, check out the python_fi_fix branch. Or wait until the PR is approved, which is the slowest option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org