You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/08 21:36:21 UTC
[jira] [Commented] (CB-11987) targetWidth and targetHeight bigger
than original picture
[ https://issues.apache.org/jira/browse/CB-11987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558759#comment-15558759 ]
ASF GitHub Bot commented on CB-11987:
-------------------------------------
GitHub user fareshan opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/238
targetWidth and targetHeight bigger than original picture
### Platforms affected
Android, iOS (i can not test for other platforms)
### What does this PR do?
When setting targetWidth and targetHeight to a bigger size than original picture, the result picture should be sized like the original picture
### What testing has been done on this change?
I tested on version 2.3.0 on iPhone and android emulators.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] CB-11987: (android, ios) Fix bug with targetWidth and targetHeight bigger than original picture
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fareshan/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit 569b069a03cf99d599cdee8e685935a706046cf4
Author: Fares Hantous <fa...@markiapp.com>
Date: 2016-10-08T20:49:21Z
prevent the creation of picture bigger than original for ios
commit 67755254fca55bd1a6ea1a38ebb835cf972617db
Author: Fares Hantous <fa...@markiapp.com>
Date: 2016-10-08T20:49:38Z
prevent the creation of picture bigger than original for android
----
> targetWidth and targetHeight bigger than original picture
> ---------------------------------------------------------
>
> Key: CB-11987
> URL: https://issues.apache.org/jira/browse/CB-11987
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Camera
> Affects Versions: 2.3.0
> Environment: android 4.4, ...
> ios 9, 10
> Reporter: Fares Hantous
> Labels: android, ios
>
> When setting targetWidth and targetHeight to a bigger size than original picture, the result picture should be sized like the original picture
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org