You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2020/12/11 05:45:00 UTC

[jira] [Commented] (YUNIKORN-482) Code coverage complaining about untouched files

    [ https://issues.apache.org/jira/browse/YUNIKORN-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247650#comment-17247650 ] 

Wilfred Spiegelenburg commented on YUNIKORN-482:
------------------------------------------------

!image-2020-12-11-16-30-46-654.png!

It looks like the detection is now saying that the tests never call {{beforeTaskCompleted()}} with an empty UUID. 

As far as I can tell it is the correct detection as I cannot find a negative test that does check this

> Code coverage complaining about untouched files
> -----------------------------------------------
>
>                 Key: YUNIKORN-482
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-482
>             Project: Apache YuniKorn
>          Issue Type: Bug
>            Reporter: Kinga Marton
>            Priority: Minor
>              Labels: coverage, pre-commit
>         Attachments: image-2020-12-11-16-30-46-654.png
>
>
> The following change: [https://github.com/apache/incubator-yunikorn-k8shim/pull/212/checks?check_run_id=1500902292]
> is complaining about decreased project coverage in a file what wasn't touched by the changes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org