You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/04/22 14:07:53 UTC

svn commit: r936806 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool: PoolUtils.java impl/EvictionTimer.java

Author: sebb
Date: Thu Apr 22 12:07:53 2010
New Revision: 936806

URL: http://svn.apache.org/viewvc?rev=936806&view=rev
Log:
Document thread-safety of static fields

Modified:
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/EvictionTimer.java

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java?rev=936806&r1=936805&r2=936806&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/PoolUtils.java Thu Apr 22 12:07:53 2010
@@ -40,7 +40,7 @@ public final class PoolUtils {
      * Timer used to periodically check pools idle object count.
      * Because a {@link Timer} creates a {@link Thread} this is lazily instantiated.
      */
-    private static Timer MIN_IDLE_TIMER;
+    private static Timer MIN_IDLE_TIMER; //@GuardedBy("this")
 
     /**
      * PoolUtils instances should NOT be constructed in standard programming.

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/EvictionTimer.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/EvictionTimer.java?rev=936806&r1=936805&r2=936806&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/EvictionTimer.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/EvictionTimer.java Thu Apr 22 12:07:53 2010
@@ -37,10 +37,10 @@ import java.util.TimerTask;
 class EvictionTimer {
     
     /** Timer instance */
-    private static Timer _timer;
+    private static Timer _timer; //@GuardedBy("this")
     
     /** Static usage count tracker */
-    private static int _usageCount;
+    private static int _usageCount; //@GuardedBy("this")
 
     /** Prevent instantiation */
     private EvictionTimer() {