You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by vadimkim <gi...@git.apache.org> on 2015/05/21 09:29:54 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed call to getLbAlgor...
GitHub user vadimkim opened a pull request:
https://github.com/apache/cloudstack/pull/273
CLOUDSTACK-8231: fixed call to getLbAlgorithms() function
Context must be not empty before calling getLbAlgorithms() function, so previous commit may cause side-effects while trying to get LB algorithms with empty context.
The list in drop-down menu is either static list of LB rules or result of getLbAlgorithms() function if it is not empty
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vadimkim/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit 7ee9b1042f35a2998217d973b5ee447ca68497fb
Author: Vadim Kimlaychuk <va...@ant.ee>
Date: 2015-05-20T19:08:29Z
CLOUDSTACK-8231: Fixed UI empty drop-down list for LB rules
commit a064911d440170185b69001deb28b8b2173b4d05
Author: Vadim Kimlaychuk <va...@ant.ee>
Date: 2015-05-21T07:18:41Z
CLOUDSTACK-8231: fixed call to getLbAlgorithms() function in order to merge results from static and dynamic data
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed call to getLbAlgor...
Posted by vadimkim <gi...@git.apache.org>.
Github user vadimkim closed the pull request at:
https://github.com/apache/cloudstack/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8231: fixed call to getLbAlgor...
Posted by vadimkim <gi...@git.apache.org>.
Github user vadimkim commented on the pull request:
https://github.com/apache/cloudstack/pull/273#issuecomment-104170005
2 commits in a raw
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---