[jira] [Commented] (CALCITE-1353) first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959952#comment-15959952 ] 

Josh Elser commented on CALCITE-1353:
-------------------------------------

Hope you don't mind, [~francischuang], stealing this one from you :)

> first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.
> -------------------------------------------------------------------------------------
>
>                 Key: CALCITE-1353
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1353
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>    Affects Versions: avatica-1.8.0
>            Reporter: Francis Chuang
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: avatica-1.10.0
>
>
> In the protobuf definition for {{ExecuteRequest}}, the {{first_frame_max_size}} parameter is typed as an {{uint64}}. See https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L130. For consistency, it should be an {{int32}}.
> Similar parameters relating to the frame size are all typed as {{int32}}.
> For a {{PrepareAndExecuteRequest}}, {{first_frame_max_size}} is a{{int32}}: https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L78
> For a {{FetchRequest}}, {{frame_max_size}} is a {{int32}}: https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/requests.proto#L96



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)