Re: [PR] [feature](statistics)Use workload group to limit statistics io. [doris]

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #39639:
URL: https://github.com/apache/doris/pull/39639#discussion_r1741070386


##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##########
@@ -336,7 +337,12 @@ public void createWorkloadGroup(CreateWorkloadGroupStmt stmt) throws DdlExceptio
                 }
                 throw new DdlException("workload group " + workloadGroupName + " already exist");
             }
-            if (idToWorkloadGroup.size() >= Config.workload_group_max_num) {
+            if (!stmt.isInternal() && workloadGroupName.equals(StatisticConstants.STATISTICS_WORKLOAD_GROUP_NAME)) {

Review Comment:
   Better use a prefix to reserve some name for internal workload group.
   eg: __doris_internal_xxx
   So that we can add other internal group in future easier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org