You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Jason Dillon <ja...@planet57.com> on 2006/07/08 05:03:50 UTC
A few tests need some help
I've reconfigured all modules to us the latest surefire plugin, and
most tests work... except for a few exceptions:
system/**/PluginInstallerTest.java
security/**/LoginKerberosTest.java
connector-builder/**/Connector15DCBTest.java
mail/**/MailcapTest.java
Each of these fail in someway that was not obvious to me why, so I
configured these specific tests to be excluded. I've removed all of
the maven.test.skip=true bits from poms and recommend that they never
be re-added. IMO, the tests must always pass and they should be
quick enough to run and thus not force people to disable them to run
builds.
All of this work is in this branch:
https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/
m2migration/
I've given up on submitting patches for the moment, but I plan on
creating an RTC issue when there is significant change to be applied
back to trunk... and will provide a patch for clarity, but recommend
that folks use this branch to test/validate on top of scanning the
patch.
I would appreciate some help in resoling why the above listed tests
are failing.
One major thing that has changed, is that the working directory for
tests has been changed from ${basedir} to ${basedir}/target, so there
were several changes needed to bind files to the correct path. IMO
this is a best practice, regardless of what the working directory
is.... tests should always use ${basedir} to root themselves and
ensure that the tests will work even when the working directory changes.
I do not believe that the failed tests listed above fail because of
this change, but it is possible that they are for reasons I do not
understand.
* * *
A side note, we should create a module that contains support classes
for unit (and integration) tests to allow some of the redundant code
to be collected, organized and maintained in a central location. I
believe we will want to implement this soon after the m2 migration is
complete and update all tests to extend from that framework to
simplify the code required to perform highly reliable testing.
Logging configuration is still a bit whack for tests... some tests
spit out a bunch of junk while others just complain with Log4j
configuration warnings. I will be resolving this shortly with the
implementation of the logging-config plugin extension, which will
allow all modules to share the same config.. BUT before this will
work we need to setup a peer project for all of the independent build
plugins.
More mail to come on that soon. I plan on setting up a project in
the sandbox, proving and example for how it works using this sandbox/
svkmerge/m2migration branch and then detailing/documenting it to the
list once it is functional.
If you have any questions or comments please let me know.
And... again, can I get someone to look at why the tests listed above
fail?
Thanks,
--jason
PS. sandbox/svkmerge/m2migration also has the latest assembly plugin
changes from GERONIMO-1737 which I am also evaluating.
Re: A few tests need some help
Posted by Jason Dillon <ja...@planet57.com>.
FYI, looks like rev #420384 should be solid to `bootstrap` off of the
svkmerge/m2migration branch.
I found the problem with commons-logging not getting picked up.
Looks like there maybe a little bug in m2 w/how it handles
<exclusions>. I've fixed the problem, but should eventually follow
up with the maven folks to see how to fix the problem.
Anyways, the only failures that I have seen so far with this branch
+rev are transient remote repository failures ("Error transferring
file", etc)... all problems which re-running the build fixes...
assuming that you can reach the remote repository.
<rant>
Seems like http://repo1.maven.org/maven2... aka m2 central is down,
or unreachable from my local network... which basically means than no
online m2 builds will function.
Remote repositories that we don't have control over really, really,
really suck.
</rant>
--jason
On Jul 9, 2006, at 3:14 PM, Jacek Laskowski wrote:
> On 7/10/06, Jason Dillon <ja...@planet57.com> wrote:
>> Note, svkmerge/m2migration is in a bit of flux at the moment...
>> results may vary.
>
> It seems to be fine so far.
>
> esis-1.0.0-SNAPSHOT.pom
> [INFO]
> [INFO]
> [INFO]
> ----------------------------------------------------------------------
> --
> [INFO] Reactor Summary:
> [INFO]
> ----------------------------------------------------------------------
> --
> [INFO] Genesis Configuration :: Clover .......................
> SUCCESS [48.094s]
> [INFO] Genesis Configuration :: Checkstyle ...................
> SUCCESS [0.078s]
> [INFO] Genesis ............................................... SUCCESS
> [2:41.047s]
> [INFO]
> ----------------------------------------------------------------------
> --
> [INFO]
> ----------------------------------------------------------------------
> --
> [INFO] BUILD SUCCESSFUL
> [INFO]
> ----------------------------------------------------------------------
> --
> [INFO] Total time: 3 minutes 30 seconds
> [INFO] Finished at: Mon Jul 10 00:12:36 CEST 2006
> [INFO] Final Memory: 5M/254M
> [INFO]
> ----------------------------------------------------------------------
> --
>
>> Ping me if you run into anything.
>
> Will do, but don't know how long I'll stay awake ;-)
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 7/10/06, Jason Dillon <ja...@planet57.com> wrote:
> Note, svkmerge/m2migration is in a bit of flux at the moment...
> results may vary.
It seems to be fine so far.
esis-1.0.0-SNAPSHOT.pom
[INFO]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] ------------------------------------------------------------------------
[INFO] Genesis Configuration :: Clover ....................... SUCCESS [48.094s]
[INFO] Genesis Configuration :: Checkstyle ................... SUCCESS [0.078s]
[INFO] Genesis ............................................... SUCCESS
[2:41.047s]
[INFO] ------------------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3 minutes 30 seconds
[INFO] Finished at: Mon Jul 10 00:12:36 CEST 2006
[INFO] Final Memory: 5M/254M
[INFO] ------------------------------------------------------------------------
> Ping me if you run into anything.
Will do, but don't know how long I'll stay awake ;-)
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jason Dillon <ja...@planet57.com>.
Note, svkmerge/m2migration is in a bit of flux at the moment...
results may vary.
Ping me if you run into anything.
--jason
On Jul 9, 2006, at 3:03 PM, Jacek Laskowski wrote:
> On 7/9/06, Jason Dillon <ja...@planet57.com> wrote:
>> You should be able to just:
>>
>> ./bootstrap
>>
>> This should build all of the bits that are currently not available in
>> any repo and then run the staged build in the proper order.
>
> Doing it now. Thanks!
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 7/9/06, Jason Dillon <ja...@planet57.com> wrote:
> You should be able to just:
>
> ./bootstrap
>
> This should build all of the bits that are currently not available in
> any repo and then run the staged build in the proper order.
Doing it now. Thanks!
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jason Dillon <ja...@planet57.com>.
You should be able to just:
./bootstrap
This should build all of the bits that are currently not available in
any repo and then run the staged build in the proper order.
We need the OpenEJB jars built with m2, which is not yet published
anywhere. TranQL used to be need to build OpenEJB, but there might
be jars published for this now... need to check, but it does not hurt
anything (except the time to wait) for this to build.
Also, recently bootstrap also builds the new Genesis branch that
contains shared build plugins, as none of these modules are published
anywhere yet either.
NOTE: Use of the bootstrap script is very temporary, and will be
dropped once required dependencies are in repos. The build script,
which simply runs the staged build in order is also temporary until
Maven can handle building extentions in the same cycle in which they
are used.
--jason
On Jul 9, 2006, at 2:24 AM, Jacek Laskowski wrote:
> On 7/8/06, Jason Dillon <ja...@planet57.com> wrote:
>
>> All of this work is in this branch:
>>
>> https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/
>> m2migration/
>
> How can I build the branch? What's the command sequence? Do I need to
> check out OpenEJB? If so, why? mvn bootstrap keeps failing for me
> because of OpenEJB not being checked out. If I don't do that step, the
> build fails with g-p-p not being found.
>
> Jacek
>
> --
> Jacek Laskowski
> http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 7/8/06, Jason Dillon <ja...@planet57.com> wrote:
> All of this work is in this branch:
>
> https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/
> m2migration/
How can I build the branch? What's the command sequence? Do I need to
check out OpenEJB? If so, why? mvn bootstrap keeps failing for me
because of OpenEJB not being checked out. If I don't do that step, the
build fails with g-p-p not being found.
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jacek Laskowski <ja...@laskowski.net.pl>.
On 7/8/06, Jason Dillon <ja...@planet57.com> wrote:
> And... again, can I get someone to look at why the tests listed above
> fail?
It aligns with my goal of improving our test base and seems to be an
excellent chance to start the work. I'm checking out the branch and am
going to give these failing tests a whirl.
Jacek
--
Jacek Laskowski
http://www.laskowski.net.pl
Re: A few tests need some help
Posted by Jason Dillon <ja...@planet57.com>.
I have not run the m1 build in a long time. I'm not sure if these
tests fail under that build or not.
--jason
On Jul 9, 2006, at 9:26 AM, Alan D. Cabrera wrote:
> Jason Dillon wrote:
>> I've reconfigured all modules to us the latest surefire plugin,
>> and most tests work... except for a few exceptions:
>>
>> system/**/PluginInstallerTest.java
>> security/**/LoginKerberosTest.java
>> connector-builder/**/Connector15DCBTest.java
>> mail/**/MailcapTest.java
>>
>> Each of these fail in someway that was not obvious to me why, so I
>> configured these specific tests to be excluded. I've removed all
>> of the maven.test.skip=true bits from poms and recommend that they
>> never be re-added. IMO, the tests must always pass and they
>> should be quick enough to run and thus not force people to disable
>> them to run builds.
>>
>> All of this work is in this branch:
>>
>> https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/
>> m2migration/
>>
>> I've given up on submitting patches for the moment, but I plan on
>> creating an RTC issue when there is significant change to be
>> applied back to trunk... and will provide a patch for clarity, but
>> recommend that folks use this branch to test/validate on top of
>> scanning the patch.
>>
>> I would appreciate some help in resoling why the above listed
>> tests are failing.
> Do you know if these are failing in trunk under m1 as well?
>
>
> Regards,
> Alan
>
>
Re: A few tests need some help
Posted by "Alan D. Cabrera" <li...@toolazydogs.com>.
Jason Dillon wrote:
> I've reconfigured all modules to us the latest surefire plugin, and
> most tests work... except for a few exceptions:
>
> system/**/PluginInstallerTest.java
> security/**/LoginKerberosTest.java
> connector-builder/**/Connector15DCBTest.java
> mail/**/MailcapTest.java
>
> Each of these fail in someway that was not obvious to me why, so I
> configured these specific tests to be excluded. I've removed all of
> the maven.test.skip=true bits from poms and recommend that they never
> be re-added. IMO, the tests must always pass and they should be quick
> enough to run and thus not force people to disable them to run builds.
>
> All of this work is in this branch:
>
>
> https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/m2migration/
>
> I've given up on submitting patches for the moment, but I plan on
> creating an RTC issue when there is significant change to be applied
> back to trunk... and will provide a patch for clarity, but recommend
> that folks use this branch to test/validate on top of scanning the patch.
>
> I would appreciate some help in resoling why the above listed tests
> are failing.
Do you know if these are failing in trunk under m1 as well?
Regards,
Alan
Re: A few tests need some help
Posted by anita kulshreshtha <a_...@yahoo.com>.
Jason,
The test failures in the security module are documented here -
http://issues.apache.org/jira/browse/GERONIMO-1672
The Connector15DCBTest failures is new. These tests used to pass in
the old trunk. There is no MailCapTest in rev. 418907. The
PluginInstallerTest is a new test added in 1.1 and needs help.
Thanks
Anita
--- Jason Dillon <ja...@planet57.com> wrote:
> I've reconfigured all modules to us the latest surefire plugin, and
> most tests work... except for a few exceptions:
>
> system/**/PluginInstallerTest.java
> security/**/LoginKerberosTest.java
> connector-builder/**/Connector15DCBTest.java
> mail/**/MailcapTest.java
>
> Each of these fail in someway that was not obvious to me why, so I
> configured these specific tests to be excluded. I've removed all of
>
> the maven.test.skip=true bits from poms and recommend that they never
>
> be re-added. IMO, the tests must always pass and they should be
> quick enough to run and thus not force people to disable them to run
>
> builds.
>
> All of this work is in this branch:
>
> https://svn.apache.org/repos/asf/geronimo/sandbox/svkmerge/
> m2migration/
>
> I've given up on submitting patches for the moment, but I plan on
> creating an RTC issue when there is significant change to be applied
>
> back to trunk... and will provide a patch for clarity, but recommend
>
> that folks use this branch to test/validate on top of scanning the
> patch.
>
> I would appreciate some help in resoling why the above listed tests
> are failing.
>
> One major thing that has changed, is that the working directory for
> tests has been changed from ${basedir} to ${basedir}/target, so there
>
> were several changes needed to bind files to the correct path. IMO
> this is a best practice, regardless of what the working directory
> is.... tests should always use ${basedir} to root themselves and
> ensure that the tests will work even when the working directory
> changes.
>
> I do not believe that the failed tests listed above fail because of
> this change, but it is possible that they are for reasons I do not
> understand.
>
> * * *
>
> A side note, we should create a module that contains support classes
>
> for unit (and integration) tests to allow some of the redundant code
>
> to be collected, organized and maintained in a central location. I
> believe we will want to implement this soon after the m2 migration is
>
> complete and update all tests to extend from that framework to
> simplify the code required to perform highly reliable testing.
>
> Logging configuration is still a bit whack for tests... some tests
> spit out a bunch of junk while others just complain with Log4j
> configuration warnings. I will be resolving this shortly with the
> implementation of the logging-config plugin extension, which will
> allow all modules to share the same config.. BUT before this will
> work we need to setup a peer project for all of the independent build
>
> plugins.
>
> More mail to come on that soon. I plan on setting up a project in
> the sandbox, proving and example for how it works using this sandbox/
>
> svkmerge/m2migration branch and then detailing/documenting it to the
>
> list once it is functional.
>
> If you have any questions or comments please let me know.
>
> And... again, can I get someone to look at why the tests listed above
>
> fail?
>
> Thanks,
>
> --jason
>
> PS. sandbox/svkmerge/m2migration also has the latest assembly plugin
>
> changes from GERONIMO-1737 which I am also evaluating.
>
>
>
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com