You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/08/03 19:38:39 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #33083: Ensure DAG-level references are filled on unmap

jedcunningham commented on code in PR #33083:
URL: https://github.com/apache/airflow/pull/33083#discussion_r1283640995


##########
airflow/models/mappedoperator.py:
##########
@@ -659,6 +659,8 @@ def unmap(self, resolve: None | Mapping[str, Any] | tuple[Context, Session]) ->
 
         op = SerializedBaseOperator(task_id=self.task_id, params=self.params, _airflow_from_mapped=True)
         SerializedBaseOperator.populate_operator(op, self.operator_class)
+        if self.dag is not None:  # For Mypy; we only serialize tasks in a DAG so the check always satisfies.
+            SerializedBaseOperator.add_operator_to_dag(op, self.dag)

Review Comment:
   ```suggestion
               SerializedBaseOperator.set_task_dag_references(op, self.dag)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org