You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2024/09/03 16:23:43 UTC
Re: (logging-parent) branch main updated: Modify review kit
Why doesn't the maven build in the review kit (below) invoke clean goal?
Gary
On Tue, Sep 3, 2024, 11:37 AM <pk...@apache.org> wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> pkarwasz pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/logging-parent.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
> new 13031ed Modify review kit
> 13031ed is described below
>
> commit 13031ede96f0234bd3c80ec98c0d012a2d94a2a1
> Author: Piotr P. Karwasz <pi...@karwasz.org>
> AuthorDate: Tue Sep 3 17:36:56 2024 +0200
>
> Modify review kit
> ---
> .github/release-review-kit.txt | 22 +++++++++++++++-------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/.github/release-review-kit.txt
> b/.github/release-review-kit.txt
> index 0ec5bc9..915dbfd 100644
> --- a/.github/release-review-kit.txt
> +++ b/.github/release-review-kit.txt
> @@ -23,19 +23,27 @@ should work universally for all projects using
>
> -----8<-----~( cut here )~-----8<-----
> # Check out the distribution
> -svn co https://dist.apache.org/repos/dist/dev/logging/... && cd $_
> +wget --cut-dirs=6 \
> + --no-host-directories \
> + --no-parent \
> + --recursive \
> +
> https://dist.apache.org/repos/dist/dev/logging/@PROJECT_NAME@/@PROJECT_VERSION@
>
> # Verify checksums
> -shasum --check *.sha512
> +sha512sum --check *.sha512
>
> # Verify signatures
> -wget -O - https://downloads.apache.org/logging/KEYS | gpg --import
> +#
> +# If you didn't import the KEYS previously, run:
> +# wget -O - https://downloads.apache.org/logging/KEYS | gpg --import
> for sigFile in *.asc; do gpg --verify $sigFile; done
>
> -# Verify reproduciblity
> +# Verify reproducibility (only Linux/MacOS X)
> umask 0022
> unzip *-src.zip -d src
> cd src
> -export NEXUS_REPO=https://repository.apache.org/content/...
> -sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO
> -# If preferred, augment `mvnw` with `-DskipTests` to speed things up
> +export NEXUS_REPO=
> https://repository.apache.org/content/repositories/orgapachelogging-
> <CHECK>
> +sh mvnw -Prelease clean verify artifact:compare
> -Dreference.repo=$NEXUS_REPO
> +
> +# Run tests only (Windows)
> +sh mvnw -Prelease clean verify artifact:compare
> \ No newline at end of file
>
>
Re: (logging-parent) branch main updated: Modify review kit
Posted by Ralph Goers <ra...@dslextreme.com>.
? Clean takes a no time. It ensures no junk is lying around.
Ralph
> On Sep 3, 2024, at 10:58 AM, Volkan Yazıcı <vo...@yazi.ci.INVALID> wrote:
>
> I will remove `clean`, since there is nothing to clean.
> We shouldn't add unnecessary overhead.
>
> On Tue, Sep 3, 2024 at 7:01 PM Piotr P. Karwasz <pi...@gmail.com>
> wrote:
>
>> Hi Gary,
>>
>> On Tue, 3 Sept 2024 at 18:25, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>> Why doesn't the maven build in the review kit (below) invoke clean goal?
>>>
>>>> +sh mvnw -Prelease clean verify artifact:compare
>>>> -Dreference.repo=$NEXUS_REPO
>>>> +
>>>> +# Run tests only (Windows)
>>>> +sh mvnw -Prelease clean verify artifact:compare
>>>> \ No newline at end of file
>>
>> Normally there is nothing to clean, but as you can see I added `clean`
>> to both UNIX and Windows.
>>
>> Piotr
>>
Re: (logging-parent) branch main updated: Modify review kit
Posted by Volkan Yazıcı <vo...@yazi.ci.INVALID>.
I will remove `clean`, since there is nothing to clean.
We shouldn't add unnecessary overhead.
On Tue, Sep 3, 2024 at 7:01 PM Piotr P. Karwasz <pi...@gmail.com>
wrote:
> Hi Gary,
>
> On Tue, 3 Sept 2024 at 18:25, Gary Gregory <ga...@gmail.com> wrote:
> >
> > Why doesn't the maven build in the review kit (below) invoke clean goal?
> >
> > > +sh mvnw -Prelease clean verify artifact:compare
> > > -Dreference.repo=$NEXUS_REPO
> > > +
> > > +# Run tests only (Windows)
> > > +sh mvnw -Prelease clean verify artifact:compare
> > > \ No newline at end of file
>
> Normally there is nothing to clean, but as you can see I added `clean`
> to both UNIX and Windows.
>
> Piotr
>
Re: (logging-parent) branch main updated: Modify review kit
Posted by "Piotr P. Karwasz" <pi...@gmail.com>.
Hi Gary,
On Tue, 3 Sept 2024 at 18:25, Gary Gregory <ga...@gmail.com> wrote:
>
> Why doesn't the maven build in the review kit (below) invoke clean goal?
>
> > +sh mvnw -Prelease clean verify artifact:compare
> > -Dreference.repo=$NEXUS_REPO
> > +
> > +# Run tests only (Windows)
> > +sh mvnw -Prelease clean verify artifact:compare
> > \ No newline at end of file
Normally there is nothing to clean, but as you can see I added `clean`
to both UNIX and Windows.
Piotr