[jira] [Commented] (FLINK-2638) Add @SafeVarargs to the environment.fromElements(...) method

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735419#comment-14735419 ] 

ASF GitHub Bot commented on FLINK-2638:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/1109

    [FLINK-2638] [core] Add @SafeVarargs to the ExecutionEnvironment's "fromElements(...)" method

    This helps to get rid of the "unchecked" warnings in places where the methods are called.
    
    The annotation states that the code can handle false generic types (added raw or through unchecked casting) without "polluting the heap", i.e. operating under false assumptions about generic parameters.
    
    I think we can add the annotation here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink safe_varargs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1109
    
----
commit 866e8e77b402640a5c08708807363b95e2fe0fbe
Author: Stephan Ewen <se...@apache.org>
Date:   2015-09-08T15:22:23Z

    [FLINK-2638] [core] Add @SafeVarargs to the ExecutionEnvironment's "fromElements(...)" method.

----


> Add @SafeVarargs to the environment.fromElements(...) method
> ------------------------------------------------------------
>
>                 Key: FLINK-2638
>                 URL: https://issues.apache.org/jira/browse/FLINK-2638
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Streaming
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 0.10
>
>
> This annotation suppresses the warnings when people use these methods with generic types.
> Since we check types and serialize them in the input format anyways, we should be actually safe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)