You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/07/17 08:48:50 UTC
[PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
raulcd opened a new pull request, #43294:
URL: https://github.com/apache/arrow/pull/43294
### Rationale for this change
The script fails to bump deb package names at the moment due to a wrong variable name.
### What changes are included in this PR?
Update the variable name to the correct one.
### Are these changes tested?
It has been tested locally to bump the versions for the debian package names on main for 17.0.0
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2234247421
Ah, we need to run `current_version` before we call `update_versions`:
```diff
diff --git a/dev/release/post-12-bump-versions.sh b/dev/release/post-12-bump-versions.sh
index 422821a66b..206da6ccb4 100755
--- a/dev/release/post-12-bump-versions.sh
+++ b/dev/release/post-12-bump-versions.sh
@@ -41,6 +41,8 @@ version=$1
next_version=$2
next_version_snapshot="${next_version}-SNAPSHOT"
+current_version_before_bump="$(current_version)"
+
case "${version}" in
*.0.0)
is_major_release=1
@@ -64,7 +66,7 @@ if [ ${BUMP_VERSION_POST_TAG} -gt 0 ]; then
fi
if [ ${BUMP_DEB_PACKAGE_NAMES} -gt 0 ] && \
- [ "${next_version}" != "$(current_version)" ]; then
+ [ "${next_version}" != "${current_version_before_bump}" ]; then
update_deb_package_names "${version}" "${next_version}"
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2232776246
:warning: GitHub issue #43284 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2233088961
I am not sure why `update_deb_package_names` is failing on the git mv here: https://github.com/apache/arrow/blob/main/dev/release/utils-prepare.sh#L239-L241
I was doing some tests locally but I don't understand what the issue is:
```
+ git mv 'debian*/lib*1701.install' debian/libarrow1800.install debian/libarrow-acero1800.install debian/libarrow-cuda1800.install debian/libarrow-cuda-glib1800.install debian/libarrow-dataset1800.install debian/libarrow-dataset-glib1800.install debian/libarrow-flight1800.install debian/libarrow-flight-glib1800.install debian/libarrow-flight-sql1800.install debian/libarrow-flight-sql-glib1800.install debian/libarrow-glib1800.install debian/libgandiva1800.install debian/libgandiva-glib1800.install debian/libparquet1800.install debian/libparquet-glib1800.install
fatal: destination 'dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib1800.install' is not a directory
```
cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix version detection timing for bump deb package names on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #43294:
URL: https://github.com/apache/arrow/pull/43294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #43294:
URL: https://github.com/apache/arrow/pull/43294#discussion_r1681696315
##########
dev/release/post-12-bump-versions.sh:
##########
@@ -64,7 +64,7 @@ if [ ${BUMP_VERSION_POST_TAG} -gt 0 ]; then
fi
if [ ${BUMP_DEB_PACKAGE_NAMES} -gt 0 ] && \
- [ "${next_version}" != "$(current_version)" ]; then
+ [ "${next_version}" != "${version}" ]; then
Review Comment:
Hmm.
`$(current_version)` is a function call not a variable reference.
So `current_version` function call is intentional here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix bump deb package names on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2238737551
Could you apply this?
```diff
diff --git a/dev/release/post-12-bump-versions-test.rb b/dev/release/post-12-bump-versions-test.rb
index 2bd1458746..f31e1a3122 100644
--- a/dev/release/post-12-bump-versions-test.rb
+++ b/dev/release/post-12-bump-versions-test.rb
@@ -358,8 +358,15 @@ class PostBumpVersionsTest < Test::Unit::TestCase
def test_deb_package_names
omit_on_release_branch unless bump_type.nil?
current_commit = git_current_commit
- stdout = bump_versions("DEB_PACKAGE_NAMES")
- changes = parse_patch(git("log", "-p", "#{current_commit}.."))
+ stdout = bump_versions("VERSION_POST_TAG", "DEB_PACKAGE_NAMES")
+ log = git("log", "-p", "#{current_commit}..")
+ # Remove a commit for VERSION_POST_TAG
+ if log.scan(/^commit/).size == 1
+ log = ""
+ else
+ log.gsub!(/\A(commit.*?)^commit .*\z/um, "\\1")
+ end
+ changes = parse_patch(log)
sampled_changes = changes.collect do |change|
first_hunk = change[:hunks][0]
first_removed_line = first_hunk.find { |line| line.start_with?("-") }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2234230482
> I am not sure why `update_deb_package_names` is failing on the git mv here: https://github.com/apache/arrow/blob/main/dev/release/utils-prepare.sh#L239-L241 I was doing some tests locally but I don't understand what the issue is:
>
> ```
> + git mv 'debian*/lib*1701.install' debian/libarrow1800.install debian/libarrow-acero1800.install debian/libarrow-cuda1800.install debian/libarrow-cuda-glib1800.install debian/libarrow-dataset1800.install debian/libarrow-dataset-glib1800.install debian/libarrow-flight1800.install debian/libarrow-flight-glib1800.install debian/libarrow-flight-sql1800.install debian/libarrow-flight-sql-glib1800.install debian/libarrow-glib1800.install debian/libgandiva1800.install debian/libgandiva-glib1800.install debian/libparquet1800.install debian/libparquet-glib1800.install
> fatal: destination 'dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib1800.install' is not a directory
> ```
This is happen because there are no files that are matched against `debian*/lib*1701.install`.
The pattern at https://github.com/apache/arrow/blob/4161898d5cd7d05ad0fd9f23e1e9df9439460c98/dev/release/utils-prepare.sh#L238 is used as-is for `git mv`. So https://github.com/apache/arrow/blob/4161898d5cd7d05ad0fd9f23e1e9df9439460c98/dev/release/utils-prepare.sh#L231 value is strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2234232180
Could you share the command line you tried?
I want to try it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix variable name on post-12-bump-versions.sh script [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2236086384
> Could you share the command line you tried? I want to try it too.
I was just trying what the test was doing on the branch:
```
BUMP_DEFAULT=0 BUMP_DEB_PACKAGE_NAMES=1 dev/release/post-12-bump-versions.sh 17.1.0 18.0.0
```
I also added the `set -x` to the `post-12-bump-versions.sh`:
```diff
diff --git a/dev/release/post-12-bump-versions.sh b/dev/release/post-12-bump-versions.sh
index 2eeb715..5ffc7d3 100755
--- a/dev/release/post-12-bump-versions.sh
+++ b/dev/release/post-12-bump-versions.sh
@@ -17,7 +17,7 @@
# specific language governing permissions and limitations
# under the License.
#
-set -ue
+set -uex
SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source "${SOURCE_DIR}/git-vars.sh"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix version detection timing for bump deb package names on post-12-bump-versions.sh script [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2241297106
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit fe5102981b762e386bc882008d587103d58cf66c.
None of the specified runs were found on the Conbench server.
The [full Conbench report](https://github.com/apache/arrow/runs/27703781814) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43284: [Release] Fix bump deb package names on post-12-bump-versions.sh script [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43294:
URL: https://github.com/apache/arrow/pull/43294#issuecomment-2238720134
(I'm writing a test for this case...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org