You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/07/14 10:08:05 UTC
Review Request 23448: Disable in-band management of OVS on
cloud_link_local_network on XenServer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/
-----------------------------------------------------------
Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
Bugs: CLOUDSTACK-7103
https://issues.apache.org/jira/browse/CLOUDSTACK-7103
Repository: cloudstack-git
Description
-------
By default XenServer uses Openvswitch and has in-band management enabled on any new network. This is not desirable for the cloud_link_local_network. This can be disabled by setting the network's other config parameter vswitch-disable-in-band to true.
Diffs
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java a9840bd
Diff: https://reviews.apache.org/r/23448/diff/
Testing
-------
Thanks,
Joris van Lieshout
Re: Review Request 23448: Disable in-band management of OVS on
cloud_link_local_network on XenServer
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
> On July 14, 2014, 8:52 a.m., daan Hoogland wrote:
> > plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java, line 4464
> > <https://reviews.apache.org/r/23448/diff/1/?file=629579#file629579line4464>
> >
> > should this only be checked for the first interface?
> > Ans should it only be set if it allready exists?
In deed I forgot the exclamation mark. Because I'm not changing the code logic (linklocal uses the first network only) I therefore do not iterate through all networks. Besides that I cannot imagine that it will contain more then one network.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/#review47710
-----------------------------------------------------------
On July 14, 2014, 9:11 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23448/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 9:11 a.m.)
>
>
> Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
>
>
> Bugs: CLOUDSTACK-7103
> https://issues.apache.org/jira/browse/CLOUDSTACK-7103
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> By default XenServer uses Openvswitch and has in-band management enabled on any new network. This is not desirable for the cloud_link_local_network. This can be disabled by setting the network's other config parameter vswitch-disable-in-band to true.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java a9840bd
>
> Diff: https://reviews.apache.org/r/23448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 23448: Disable in-band management of OVS on
cloud_link_local_network on XenServer
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/#review47710
-----------------------------------------------------------
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/23448/#comment83886>
please remove tabs
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
<https://reviews.apache.org/r/23448/#comment83887>
should this only be checked for the first interface?
Ans should it only be set if it allready exists?
- daan Hoogland
On July 14, 2014, 8:08 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23448/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 8:08 a.m.)
>
>
> Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
>
>
> Bugs: CLOUDSTACK-7103
> https://issues.apache.org/jira/browse/CLOUDSTACK-7103
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> By default XenServer uses Openvswitch and has in-band management enabled on any new network. This is not desirable for the cloud_link_local_network. This can be disabled by setting the network's other config parameter vswitch-disable-in-band to true.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java a9840bd
>
> Diff: https://reviews.apache.org/r/23448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 23448: Disable in-band management of OVS on
cloud_link_local_network on XenServer
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/#review47770
-----------------------------------------------------------
Ship it!
e8c32c7f5b21edda8cb67b2d477cf34e1faeb677
- daan Hoogland
On July 14, 2014, 9:11 a.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23448/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 9:11 a.m.)
>
>
> Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
>
>
> Bugs: CLOUDSTACK-7103
> https://issues.apache.org/jira/browse/CLOUDSTACK-7103
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> By default XenServer uses Openvswitch and has in-band management enabled on any new network. This is not desirable for the cloud_link_local_network. This can be disabled by setting the network's other config parameter vswitch-disable-in-band to true.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java a9840bd
>
> Diff: https://reviews.apache.org/r/23448/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 23448: Disable in-band management of OVS on
cloud_link_local_network on XenServer
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23448/
-----------------------------------------------------------
(Updated July 14, 2014, 9:11 a.m.)
Review request for cloudstack, Alex Huang, daan Hoogland, and Hugo Trippaers.
Changes
-------
Removed tabs and add missing exclamation mark
Bugs: CLOUDSTACK-7103
https://issues.apache.org/jira/browse/CLOUDSTACK-7103
Repository: cloudstack-git
Description
-------
By default XenServer uses Openvswitch and has in-band management enabled on any new network. This is not desirable for the cloud_link_local_network. This can be disabled by setting the network's other config parameter vswitch-disable-in-band to true.
Diffs (updated)
-----
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java a9840bd
Diff: https://reviews.apache.org/r/23448/diff/
Testing
-------
Thanks,
Joris van Lieshout