You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "xuziyang (via GitHub)" <gi...@apache.org> on 2023/09/01 09:11:42 UTC
[GitHub] [shenyu] xuziyang opened a new pull request, #5107: [type:refactor] Put the creation logic of HttpClient in a separate class
xuziyang opened a new pull request, #5107:
URL: https://github.com/apache/shenyu/pull/5107
The creation logic of HttpClient is too complicated. A better way than putting it in the HttpClientPluginConfiguration is to write it into a separate class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #5107: [type:refactor] Put the creation logic of HttpClient in a separate class
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 merged PR #5107:
URL: https://github.com/apache/shenyu/pull/5107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #5107: [type:refactor] Put the creation logic of HttpClient in a separate class
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5107:
URL: https://github.com/apache/shenyu/pull/5107#issuecomment-1702460248
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5107](https://app.codecov.io/gh/apache/shenyu/pull/5107?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d9a6391) into [master](https://app.codecov.io/gh/apache/shenyu/commit/74cc3010a0cd539339c7e0cee17b3d40dcf2e773?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (74cc301) will **decrease** coverage by `0.16%`.
> Report is 1 commits behind head on master.
> The diff coverage is `48.05%`.
> :exclamation: Current head d9a6391 differs from pull request most recent head cb4230e. Consider uploading reports for the commit cb4230e to get more accurate results
```diff
@@ Coverage Diff @@
## master #5107 +/- ##
============================================
- Coverage 61.81% 61.65% -0.16%
+ Complexity 8497 8482 -15
============================================
Files 1227 1228 +1
Lines 36963 36958 -5
Branches 3514 3511 -3
============================================
- Hits 22849 22787 -62
- Misses 12156 12216 +60
+ Partials 1958 1955 -3
```
| [Files Changed](https://app.codecov.io/gh/apache/shenyu/pull/5107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...t/starter/plugin/httpclient/HttpClientFactory.java](https://app.codecov.io/gh/apache/shenyu/pull/5107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1odHRwY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9odHRwY2xpZW50L0h0dHBDbGllbnRGYWN0b3J5LmphdmE=) | `47.36% <47.36%> (ø)` | |
| [...ugin/httpclient/HttpClientPluginConfiguration.java](https://app.codecov.io/gh/apache/shenyu/pull/5107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1odHRwY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9odHRwY2xpZW50L0h0dHBDbGllbnRQbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `81.25% <100.00%> (+30.67%)` | :arrow_up: |
... and [33 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5107/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org