You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Nadeesh Dilanga <na...@gmail.com> on 2016/07/11 05:39:37 UTC
Docker Activity Create/Start/List Container support
Hi,
I worked this week on implementing this. I have sent 3 more new pull
requests.
Here I have added Docker Activity support for Create/Start and List
containers. This also came with pre defined port bindings capability also.
I have tested this with a docker sample python application and was able to
browse the application(hello world) form web browser. I took screen shots
on those. I will probably create a user guide end of this project with
screen shots on how to run a container from scratch.
Right now everything is part if JUnit tests which is self descriptive. Can
you please review the pull requests(I saw four pull request to be merged at
the moment) and also any feedback of improvement.
I will implement stop/delete container support for Activity Plugin also and
send a another pull request.
One other thing to note is, output from the docker activity plugin is
always a JSON.
Re: Docker Activity Create/Start/List Container support
Posted by Nadeesh Dilanga <na...@gmail.com>.
Hi Alan,
Thank you very much for the feedback. I have sent a pull request with all
the recommended fixes.
On Tue, Jul 12, 2016 at 12:11 AM, Nadeesh Dilanga <na...@gmail.com>
wrote:
> Hi Stian,
> Actually I have the screen capture in my local disk. Will upload a README
> PDF to a separate JIRA by the end of the implementation.
>
> On Mon, Jul 11, 2016 at 5:54 AM, Alan Williams <al...@googlemail.com>
> wrote:
>
>> On 11-Jul-16 06:39, Nadeesh Dilanga wrote:
>>
>>> Hi,
>>> I worked this week on implementing this. I have sent 3 more new pull
>>> requests.
>>>
>>
>> Great. I will have a look.
>>
>> Here I have added Docker Activity support for Create/Start and List
>>> containers. This also came with pre defined port bindings capability
>>> also.
>>> I have tested this with a docker sample python application and was able
>>> to
>>> browse the application(hello world) form web browser. I took screen shots
>>> on those.
>>>
>>
>> Where are the screen shots kept?
>>
>> I will probably create a user guide end of this project with
>>> screen shots on how to run a container from scratch.
>>>
>>> Right now everything is part if JUnit tests which is self descriptive.
>>> Can
>>> you please review the pull requests(I saw four pull request to be merged
>>> at
>>> the moment) and also any feedback of improvement.
>>>
>>> I will implement stop/delete container support for Activity Plugin also
>>> and
>>> send a another pull request.
>>>
>>> One other thing to note is, output from the docker activity plugin is
>>> always a JSON.
>>>
>>
>> OK
>>
>> Alan
>>
>>
>
Re: Docker Activity Create/Start/List Container support
Posted by Nadeesh Dilanga <na...@gmail.com>.
Hi Stian,
Actually I have the screen capture in my local disk. Will upload a README
PDF to a separate JIRA by the end of the implementation.
On Mon, Jul 11, 2016 at 5:54 AM, Alan Williams <al...@googlemail.com>
wrote:
> On 11-Jul-16 06:39, Nadeesh Dilanga wrote:
>
>> Hi,
>> I worked this week on implementing this. I have sent 3 more new pull
>> requests.
>>
>
> Great. I will have a look.
>
> Here I have added Docker Activity support for Create/Start and List
>> containers. This also came with pre defined port bindings capability also.
>> I have tested this with a docker sample python application and was able to
>> browse the application(hello world) form web browser. I took screen shots
>> on those.
>>
>
> Where are the screen shots kept?
>
> I will probably create a user guide end of this project with
>> screen shots on how to run a container from scratch.
>>
>> Right now everything is part if JUnit tests which is self descriptive. Can
>> you please review the pull requests(I saw four pull request to be merged
>> at
>> the moment) and also any feedback of improvement.
>>
>> I will implement stop/delete container support for Activity Plugin also
>> and
>> send a another pull request.
>>
>> One other thing to note is, output from the docker activity plugin is
>> always a JSON.
>>
>
> OK
>
> Alan
>
>
Re: Docker Activity Create/Start/List Container support
Posted by Alan Williams <al...@googlemail.com>.
On 11-Jul-16 06:39, Nadeesh Dilanga wrote:
> Hi,
> I worked this week on implementing this. I have sent 3 more new pull
> requests.
Great. I will have a look.
> Here I have added Docker Activity support for Create/Start and List
> containers. This also came with pre defined port bindings capability also.
> I have tested this with a docker sample python application and was able to
> browse the application(hello world) form web browser. I took screen shots
> on those.
Where are the screen shots kept?
>I will probably create a user guide end of this project with
> screen shots on how to run a container from scratch.
>
> Right now everything is part if JUnit tests which is self descriptive. Can
> you please review the pull requests(I saw four pull request to be merged at
> the moment) and also any feedback of improvement.
>
> I will implement stop/delete container support for Activity Plugin also and
> send a another pull request.
>
> One other thing to note is, output from the docker activity plugin is
> always a JSON.
OK
Alan