You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/07/19 15:53:38 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #6038: Remove a struct only used by the removed /profiles/trimmed TO API endpoint
ocket8888 opened a new pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038
## What does this PR (Pull Request) do?
- [x] This PR is not related to any Issue
This PR removes a struct that was only used to represent the response to the now-removed `/profiles/trimmed` Traffic Ops APIv1 route.
## Which Traffic Control components are affected by this PR?
None, the struct was unused.
## What is the best way to verify this PR?
Make sure all existing tests still pass.
## The following criteria are ALL met by this PR
- [x] Tests are unnecessary
- [x] Documentation is unnecessary
- [x] An update to CHANGELOG.md is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038#issuecomment-882713057
While you're at it, my IDE found that these unused functions which may or may not be remnants of v1:
```
handler.go: SnapshotOldGetHandler
monitoring.go: Get
name.go: GetName
routes.go: notImplementedHandler
keys.go: getCDNIDByDomainName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038#issuecomment-882713057
While you're at it, my IDE found that these unused functions which may or may not be remnants of v1:
```
handler.go: SnapshotOldGetHandler
monitoring.go: Get
name.go: GetName
routes.go: notImplementedHandler
keys.go: getCDNIDByDomainName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp edited a comment on pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp edited a comment on pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038#issuecomment-882713057
While you're at it, my IDE found these unused functions which may or may not be remnants of v1:
```
handler.go: SnapshotOldGetHandler
monitoring.go: Get
name.go: GetName
routes.go: notImplementedHandler
keys.go: getCDNIDByDomainName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp edited a comment on pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp edited a comment on pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038#issuecomment-882713057
While you're at it, my IDE found these unused functions which may or may not be remnants of v1:
```
handler.go: SnapshotOldGetHandler
monitoring.go: Get
name.go: GetName
routes.go: notImplementedHandler
keys.go: getCDNIDByDomainName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038#issuecomment-882713057
While you're at it, my IDE found that these unused functions which may or may not be remnants of v1:
```
handler.go: SnapshotOldGetHandler
monitoring.go: Get
name.go: GetName
routes.go: notImplementedHandler
keys.go: getCDNIDByDomainName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp edited a comment on pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp edited a comment on pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038#issuecomment-882713057
While you're at it, my IDE found these unused functions which may or may not be remnants of v1:
```
handler.go: SnapshotOldGetHandler
monitoring.go: Get
name.go: GetName
routes.go: notImplementedHandler
keys.go: getCDNIDByDomainName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #6038: Remove structs/funcs only used by the removed TO API version 1
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6038:
URL: https://github.com/apache/trafficcontrol/pull/6038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org