You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/04/09 17:14:54 UTC

[GitHub] [drill] KazydubB opened a new pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

KazydubB opened a new pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup
URL: https://github.com/apache/drill/pull/2050
 
 
   # [DRILL-7694](https://issues.apache.org/jira/browse/DRILL-7694): Register drill.queries.* counter metrics on Drillbit startup
   
   ## Description
   
   Currently these query state (`drill.queries.*`) counter metrics are registered when the first query on Drillbit is issued but should be registered when Drillbit is started because having `0` running/completed/etc. queries is itself a valid metric. Moreover, absence of these metrics can cause warnings in logs indicating there is no registered bean for such a metric or cause errors in case when no query was issued. 
   
   ## Documentation
   N/A
   
   ## Testing
   Ran existing test suit and unit tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] arina-ielchiieva commented on issue #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup
URL: https://github.com/apache/drill/pull/2050#issuecomment-612414695
 
 
   +1, LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] KazydubB commented on a change in pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

Posted by GitBox <gi...@apache.org>.
KazydubB commented on a change in pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup
URL: https://github.com/apache/drill/pull/2050#discussion_r406834821
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/exec/metrics/DrillCounters.java
 ##########
 @@ -0,0 +1,53 @@
+package org.apache.drill.exec.metrics;
+
+import com.codahale.metrics.Counter;
+
+public class DrillCounters {
 
 Review comment:
   Done, please look if anything should be changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on a change in pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup
URL: https://github.com/apache/drill/pull/2050#discussion_r406811541
 
 

 ##########
 File path: common/src/main/java/org/apache/drill/exec/metrics/DrillCounters.java
 ##########
 @@ -0,0 +1,53 @@
+package org.apache.drill.exec.metrics;
+
+import com.codahale.metrics.Counter;
+
+public class DrillCounters {
 
 Review comment:
   Please add java doc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [drill] asfgit closed pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2050: DRILL-7694: Register drill.queries.* counter metrics on Drillbit startup
URL: https://github.com/apache/drill/pull/2050
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services