You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/05/26 15:25:41 UTC

[GitHub] [maven-surefire] pzygielo edited a comment on issue #234: (doc) add static modifier to signatures

pzygielo edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496008928
 
 
   > The implementation is right as well.
   
   Then it isn't as proved by 355ed4cb63de46fe98aa749ab69832df5586137b and code linked in https://github.com/apache/maven-surefire/pull/234#issuecomment-495985222.
   
   instance method `setUp` is accepted by `isValidTestMethod` and then ruled out by conditions in https://github.com/apache/maven-surefire/blob/33360045e005b38b16eb2c6d1169f43de927bb3d/surefire-providers/surefire-junit3/src/main/java/org/apache/maven/surefire/junit/PojoTestSet.java#L234
   and never processed by https://github.com/apache/maven-surefire/blob/33360045e005b38b16eb2c6d1169f43de927bb3d/surefire-providers/surefire-junit3/src/main/java/org/apache/maven/surefire/junit/PojoTestSet.java#L240
   The same for `tearDown`.
   
   My PR was to update documentation to follow current implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services