[jira] [Commented] (DIRKRB-251) Create test for udp & tcp separatedly using NettyKdcNetwork

["Lin Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRKRB-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537052#comment-14537052 ] 

Lin Chen commented on DIRKRB-251:
---------------------------------

Hi Yaning,
In the patch, the two classes have a lot of the same codes. Could you please simplify the patch? What's more, for the class name {{OnlyTcpForNettyKdcNetworkTest}} and {{OnlyUdpForNettyKdcNetworkTest}}, we can not find out it is json backup test, right?

> Create test for udp & tcp separatedly using NettyKdcNetwork
> -----------------------------------------------------------
>
>                 Key: DIRKRB-251
>                 URL: https://issues.apache.org/jira/browse/DIRKRB-251
>             Project: Directory Kerberos
>          Issue Type: Test
>            Reporter: Xu Yaning
>            Assignee: Xu Yaning
>         Attachments: DIRKRB-251-v1.patch
>
>
> Tcp test and udp test for NettyKdcNetwork are both in {{JsonBackendKdcTest.java}}, which makes it confusing whether tcp or udp works. So it is natural to separate the test for them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)