[GitHub] [incubator-superset] ktmud commented on pull request #9637: [WIP][explore view] add partition as adhoc filter option

[GitBox <gi...@apache.org>]

ktmud commented on pull request #9637:
URL: https://github.com/apache/incubator-superset/pull/9637#issuecomment-618692895


   This seems to target some specific use cases while different companies/data pipelines may use partitions differently. AFAIK, there can be two cases when a datetime column is used as partition keys:
   
   1. daily snapshots of full tables, such as product inventory, registered users, etc.
   2. incremental logs, where each partition only contains new data in the given time period.
   
   This feature would be very useful for the first scenario, but not so much for the second, and probably even less for a non-datetime column such as `cluster` in the example.
   
   Questions and suggestions:
   
   1. Partitions have hierarchies, in the example `hr` is probably subfolders within `date`, does selecting `hr` mean using the latest `hr` partition from the latest `date`?
   2. Instead of adding a new tab, how make the filter value an option list with a "Latest partition" option:
      
      ![Slice 4](https://user-images.githubusercontent.com/335541/80153479-742b9280-8572-11ea-8d34-41ea07cda45e.png)
   
      It can be a "Creatable" `SelectControl` with only one option that has label "Latest parition" and value of `presto.latest_partition(...)`.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org