[whimsy] branch master updated: This should be a local variable

[se...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new ca068c9  This should be a local variable
ca068c9 is described below

commit ca068c99ba9b51a8d03e6a233bf577c6ef3db9bf
Author: Sebb <se...@apache.org>
AuthorDate: Fri Aug 20 17:31:14 2021 +0100

    This should be a local variable
---
 www/secretary/workbench/views/forms/icla.js.rb | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/www/secretary/workbench/views/forms/icla.js.rb b/www/secretary/workbench/views/forms/icla.js.rb
index 33091c6..b7b9a56 100644
--- a/www/secretary/workbench/views/forms/icla.js.rb
+++ b/www/secretary/workbench/views/forms/icla.js.rb
@@ -151,10 +151,10 @@ class ICLA < Vue
 
     @realname = name
     @pubname = parsed.PublicName || name
-    @pubnamearray = @pubname.split(" ")
+    pubnamearray = @pubname.split(" ")
     @familyfirst = parsed.FamilyFirst || false
-    @ldapsn = self.genldapsn(@pubnamearray, @familyfirst)
-    @ldapgivenname = self.genldapgivenname(@pubnamearray, @familyfirst)
+    @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
+    @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
     @filename = self.genfilename(name, @familyfirst)
     @email = parsed.EMail || @@headers.from
     @user = parsed.ApacheID || ''
@@ -252,17 +252,17 @@ class ICLA < Vue
   # when family first changes, update file name and LDAP default fields
   def changeFamilyFirst(event)
     @filename = self.genfilename(@realname, @familyfirst)
-    @pubnamearray = @pubname.split(' ')
-    @ldapsn = self.genldapsn(@pubnamearray, @familyfirst)
-    @ldapgivenname = self.genldapgivenname(@pubnamearray, @familyfirst)
+    pubnamearray = @pubname.split(' ')
+    @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
+    @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
   end
 
   # when public name changes, update LDAP default fields
   def changePublicName(event)
     @pubname = event.target.value;
-    @pubnamearray = @pubname.split(' ')
-    @ldapsn = self.genldapsn(@pubnamearray, @familyfirst)
-    @ldapgivenname = self.genldapgivenname(@pubnamearray, @familyfirst)
+    pubnamearray = @pubname.split(' ')
+    @ldapsn = self.genldapsn(pubnamearray, @familyfirst)
+    @ldapgivenname = self.genldapgivenname(pubnamearray, @familyfirst)
   end
 
   # generate file name from the real name