You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "wuchunfu (via GitHub)" <gi...@apache.org> on 2024/06/18 13:10:13 UTC
Re: [PR] [improve][UI] update dependencies && remove useless code [seatunnel-web]
wuchunfu commented on code in PR #164:
URL: https://github.com/apache/seatunnel-web/pull/164#discussion_r1644440500
##########
seatunnel-ui/src/App.tsx:
##########
@@ -15,24 +15,25 @@
* limitations under the License.
*/
-import { defineComponent, computed, watch, ref } from 'vue'
+import { useSettingStore } from '@/store/setting'
+import { useThemeStore } from '@/store/theme'
+import themeList from '@/themes'
import {
NConfigProvider,
- NMessageProvider,
NDialogProvider,
+ NMessageProvider,
darkTheme,
- dateZhCN,
dateEnUS,
- zhCN,
- enUS
+ dateZhCN,
+ enUS,
+ zhCN
} from 'naive-ui'
-import { useThemeStore } from '@/store/theme'
-import { useSettingStore } from '@/store/setting'
+import type {
+ CustomThemeCommonVars,
+ ThemeCommonVars
+} from 'naive-ui/es/config-provider/src/interface'
+import { computed, defineComponent, watch } from 'vue'
import { useI18n } from 'vue-i18n'
-import themeList from '@/themes'
-import type { GlobalThemeOverrides } from 'naive-ui'
-import type { Ref } from 'vue'
-import type { CustomThemeCommonVars, ThemeCommonVars } from 'naive-ui/es/config-provider/src/interface'
Review Comment:
@baicie I think these are non essential changes that need to be made, and there is no need to format them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org