[GitHub] [arrow] nealrichardson commented on a change in pull request #7524: ARROW-8899 [R] Add R metadata like pandas metadata for round-trip fidelity

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #7524:
URL: https://github.com/apache/arrow/pull/7524#discussion_r444306795



##########
File path: r/tests/testthat/test-Table.R
##########
@@ -334,5 +334,5 @@ test_that("Table metadata", {
 
 test_that("Table handles null type (ARROW-7064)", {
   tab <- Table$create(a = 1:10, n = vctrs::unspecified(10))
-  expect_equal(tab$schema,  schema(a = int32(), n = null()))
+  expect_true(tab$schema$Equals(schema(a = int32(), n = null()), FALSE))

Review comment:
       I think you can use `expect_equivalent()` instead of `expect_equal` and it will skip the metadata comparison; cf. https://github.com/apache/arrow/blob/master/r/R/arrow-package.R#L111 
   
   (of course, we'll have to fix this for the new version of `testthat` that doesn't use all.equal under the hood)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org