You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2007/12/14 21:21:57 UTC
[jira] Created: (MRRESOURCES-30) When comparing organizations,
don't compare the url
When comparing organizations, don't compare the url
---------------------------------------------------
Key: MRRESOURCES-30
URL: http://jira.codehaus.org/browse/MRRESOURCES-30
Project: Maven 2.x Remote Resources Plugin
Issue Type: Bug
Affects Versions: 1.0-beta-2, 1.0-alpha-6
Reporter: Dennis Lundberg
Attachments: NOTICE
The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRRESOURCES-30) When comparing organizations,
don't compare the url
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MRRESOURCES-30:
----------------------------------
Fix Version/s: (was: 1.1)
1.2
I'm not sure I understand this issue or the relevant use cases well enough to fix it. I'd like to push it to 1.2 unless someone has enough time to get it resolved in the next week or two.
> When comparing organizations, don't compare the url
> ---------------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Bug
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Fix For: 1.2
>
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRRESOURCES-30) Make the organization comparator
configurable
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MRRESOURCES-30:
---------------------------------------
Issue Type: New Feature (was: Bug)
Summary: Make the organization comparator configurable (was: When comparing organizations, don't compare the url)
> Make the organization comparator configurable
> ---------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: New Feature
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Fix For: 1.2
>
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-30) When comparing organizations,
don't compare the url
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172171#action_172171 ]
Jason van Zyl commented on MRRESOURCES-30:
------------------------------------------
So is this a won't fix?
> When comparing organizations, don't compare the url
> ---------------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Bug
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-30) When comparing organizations,
don't compare the url
Posted by "Daniel Kulp (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_127507 ]
Daniel Kulp commented on MRRESOURCES-30:
----------------------------------------
I disagree with this. When implementing the sorting stuff, I did run originally just use the organization name for sorting, but due to a bunch of bad poms, the results were not correct and not reproduceable.
For example, we depend on a BUNCH of stuff at Apache. However, the poms put different organization URL's in there all over the place. (The jakarta folks are really bad) The resulting NOTICE would pretty much pick different values for the ${organization.url} parameter depending on the JDK, OS, etc... And most of the time, it wasn't correct.
SOMETIMES, we would get the (almost) correct:
Apache Software Foundation (http://www.apache.org/)
but many times we would get:
The Apache Software Foundation (http://jakarta.apache.org)
or other variations that are just wrong. Thus, I decided to keep the URL as part of the sort so that the projects that DO put the correct information in their poms (or inherit from the appropriate apache parent) aren't screwed up by the projects that don't do the right things.
> When comparing organizations, don't compare the url
> ---------------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Bug
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRRESOURCES-30) Make the organization comparator
configurable
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg updated MRRESOURCES-30:
---------------------------------------
Fix Version/s: (was: 1.2)
> Make the organization comparator configurable
> ---------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: New Feature
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-30) When comparing organizations,
don't compare the url
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172257#action_172257 ]
Dennis Lundberg commented on MRRESOURCES-30:
--------------------------------------------
Taking into account Daniel's comment I'd change this from a bug to a new feature request, and change the title to something like "Make the organization comparator configurable". Thus we could supply two comparators out of the box. The current implementation would be the default one. I could write another one that would only look at the organizations name and ignore the URL. We can make this configurable, to allow other Comparators to be used as well.
> When comparing organizations, don't compare the url
> ---------------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Bug
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRRESOURCES-30) Make the organization comparator
configurable
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MRRESOURCES-30.
--------------------------------------
Resolution: Won't Fix
> Make the organization comparator configurable
> ---------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: New Feature
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Fix For: 1.2
>
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRRESOURCES-30) When comparing organizations,
don't compare the url
Posted by "sebbaz+ch (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRRESOURCES-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116858 ]
sebbaz+ch commented on MRRESOURCES-30:
--------------------------------------
Or perhaps have a list of aliases for names and URLs?
> When comparing organizations, don't compare the url
> ---------------------------------------------------
>
> Key: MRRESOURCES-30
> URL: http://jira.codehaus.org/browse/MRRESOURCES-30
> Project: Maven 2.x Remote Resources Plugin
> Issue Type: Bug
> Affects Versions: 1.0-alpha-6, 1.0-beta-2
> Reporter: Dennis Lundberg
> Attachments: NOTICE
>
>
> The OrganizationComparator in ProcessRemoteResourcesMojo takes into account both the organization's name *and* url. This leads to strange generated NOTICE files, like the one attached, which comes from a slightly modified trunk of commons-validator. I feel that the comparator should be changed so that it only compares the name of the organization. An alternative way would be to have two configurable comparators to choose from. I'm willing to do the coding, but want to solicit other's opinions first.
> Also see discussions here: https://issues.apache.org/jira/browse/COMMONSSITE-21
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira