You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sa...@gmail.com> on 2019/02/19 22:42:00 UTC

Regarding variable name 1.10.0 ordinal?

I am in process of adding a new ordinal for 1.10.0 and see that currently
the variables are named as GEODE_XYZ for a release x.y.x (eg, private
static final byte GEODE_1100_ORDINAL = 105;)

Question is are there any side effects for naming it as GEODE_1100_ORDINAL
for 1.10.0?
Not sure if there is a better way of doing this.

Sai

Re: Regarding variable name 1.10.0 ordinal?

Posted by Bruce Schuchardt <bs...@pivotal.io>.
The backward-compatibility serialization methods based on 
Version.methodSuffix already add underscores between the 
major/minor/release numbers.  I think it would be nice to rename all of 
the ordinals and versions to use the same convention, like 
GEODE_1_10_0_ORDINAL


On 2/19/19 2:42 PM, Sai Boorlagadda wrote:
> I am in process of adding a new ordinal for 1.10.0 and see that currently
> the variables are named as GEODE_XYZ for a release x.y.x (eg, private
> static final byte GEODE_1100_ORDINAL = 105;)
>
> Question is are there any side effects for naming it as GEODE_1100_ORDINAL
> for 1.10.0?
> Not sure if there is a better way of doing this.
>
> Sai
>