You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yuqi Du (Code Review)" <ge...@cloudera.org> on 2022/07/19 16:41:46 UTC
[kudu-CR] [log] make two line logs more clearly
Yuqi Du has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18749
Change subject: [log] make two line logs more clearly
......................................................................
[log] make two line logs more clearly
Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
---
M src/kudu/master/master_main.cc
M src/kudu/tserver/tablet_server_main.cc
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/18749/1
--
To view, visit http://gerrit.cloudera.org:8080/18749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
Gerrit-Change-Number: 18749
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
[kudu-CR] [log] make two line logs more clearly
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18749 )
Change subject: [log] make two line logs more clearly
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18749/1/src/kudu/master/master_main.cc
File src/kudu/master/master_main.cc:
http://gerrit.cloudera.org:8080/#/c/18749/1/src/kudu/master/master_main.cc@36
PS1, Line 36: parse command line flags error,
Why would anybody be interested to know that it's ParseCommandLineFlags() that returned an error? How is that helpful to the end-user?
--
To view, visit http://gerrit.cloudera.org:8080/18749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
Gerrit-Change-Number: 18749
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Jul 2022 17:45:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [log] make two line logs more clearly
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18749 )
Change subject: [log] make two line logs more clearly
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18749/1/src/kudu/master/master_main.cc
File src/kudu/master/master_main.cc:
http://gerrit.cloudera.org:8080/#/c/18749/1/src/kudu/master/master_main.cc@36
PS1, Line 36: parse command line flags error,
> For example, at a vert complex start_tserver.sh, obtain flags infomations a
I think other changelist makes it more clear what's going on and also produces an actionable error message:
https://gerrit.cloudera.org/#/c/19253/
--
To view, visit http://gerrit.cloudera.org:8080/18749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
Gerrit-Change-Number: 18749
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Nov 2022 05:58:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [log] make two line logs more clearly
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18749 )
Change subject: [log] make two line logs more clearly
......................................................................
Patch Set 1:
> Patch Set 1:
>
> (1 comment)
OK. I close this and review that patch.
--
To view, visit http://gerrit.cloudera.org:8080/18749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
Gerrit-Change-Number: 18749
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Fri, 18 Nov 2022 12:01:07 +0000
Gerrit-HasComments: No
[kudu-CR] [log] make two line logs more clearly
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18749 )
Change subject: [log] make two line logs more clearly
......................................................................
Patch Set 1:
(1 comment)
Thanks your cr.
http://gerrit.cloudera.org:8080/#/c/18749/1/src/kudu/master/master_main.cc
File src/kudu/master/master_main.cc:
http://gerrit.cloudera.org:8080/#/c/18749/1/src/kudu/master/master_main.cc@36
PS1, Line 36: parse command line flags error,
> Why would anybody be interested to know that it's ParseCommandLineFlags() t
For example, at a vert complex start_tserver.sh, obtain flags infomations and start kudu tserver.
(the example is my own special kudu-tserver). At the end the command:
```
bin/kudu-server --disable_core_dumps=true --webserver_port=8070 --rpc_bind_addresses=0.0.0.0:7070 --superuser_acl=kudu,root,sa_cluster --max_clock_sync_error_usec=100000000 --downstream_type=kafka --kafka_queue_length=15000 --kafka_target_topic=9 9 kudu_profile_record_stream --sync_history_data=false --memory_limit_hard_bytes=27013989990 --tablet_transaction_memory_limit_mb=128 --sleep_second_per_epoch=0 --trusted_subnets=0.0.0.0/0 --rpc_authentication=disabled --rpc_encryption=disabled --tserver_master_addrs=data03:7051,data02:7051,data01:7051 --log_dir=/metadata/sa_cluster/logs/infinity/ksyncer_kafka --fs_data_dirs=/data1/sa_cluster/ksyncer_kafka/ksyncer_data --fs_wal_dir=/data1/sa_cluster/ksyncer_kafka/ksyncer_wal --kafka_broker_list=data04:9092,data05:9092,data06:9092,data07:9092,data08:9092
usage: bin/kudu-tserver
```
In fact, for some special reason, topic_name is error. But the error output is hard to help me, it’s Inconspicuous.
If the usage is more clearly, it can save time to address the problem.
--
To view, visit http://gerrit.cloudera.org:8080/18749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
Gerrit-Change-Number: 18749
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Jul 2022 03:43:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [log] make two line logs more clearly
Posted by "Yuqi Du (Code Review)" <ge...@cloudera.org>.
Yuqi Du has abandoned this change. ( http://gerrit.cloudera.org:8080/18749 )
Change subject: [log] make two line logs more clearly
......................................................................
Abandoned
https://gerrit.cloudera.org/c/19253/, the patch includes my patch.
--
To view, visit http://gerrit.cloudera.org:8080/18749
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic4adbcb171473eca4a534ddbb7f438779d859d2d
Gerrit-Change-Number: 18749
Gerrit-PatchSet: 1
Gerrit-Owner: Yuqi Du <sh...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>