[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5843: Change `FileFormat` to depends on `TaskContext` rather than `SessionState`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5843:
URL: https://github.com/apache/arrow-datafusion/pull/5843#discussion_r1155848115


##########
datafusion/core/src/datasource/file_format/avro.rs:
##########
@@ -48,7 +48,7 @@ impl FileFormat for AvroFormat {
 
     async fn infer_schema(
         &self,
-        _state: &SessionState,
+        _task_ctx: &TaskContext,

Review Comment:
   The point of this PR is to change the `SessionState` references in these traits to `TaskContext`



##########
datafusion/core/src/execution/context.rs:
##########
@@ -1176,7 +1178,14 @@ impl QueryPlanner for DefaultQueryPlanner {
     }
 }
 
-/// Execution context for registering data sources and executing queries
+/// Holds state needed for planning queries within the context of a Session.

Review Comment:
   Tried to clarify SessionState vs TaskContext



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org