[jira] Commented: (JCR-940) add db connection autoConnect for BundleDbPersistenceManager.

["Stefan Guggisberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522184 ] 

Stefan Guggisberg commented on JCR-940:
---------------------------------------

martijn, thanks for the patch. the patch looks very good in general, excellent job!

i quickly browsed through the patch and i got a few comments:

- some changes in BundleDbPersistenceManager seem to have gone lost
   in your patch (e.g. #566385 & #563900). 

- Oracle9PersistenceManager#storeBundle: the blob parameter is never set ;-)

- what was the reason for removing resetStatement(stmt) calls? 
  (see e.g. PostgreSQLPersistenceManager line 120)

- tabs should be avoided in the source code

cheers
stefan

> add db connection autoConnect for BundleDbPersistenceManager.
> -------------------------------------------------------------
>
>                 Key: JCR-940
>                 URL: https://issues.apache.org/jira/browse/JCR-940
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Xiaohua Lu
>         Attachments: JCR-940.patch
>
>
> Since bundled db pm doesn't inherited from database pm, it can't reconnect once database is bounced. it would be nice to add this feature. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.