[GitHub] HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Inject necessary casts when data type of columns and matching type of fields are not equal

[GitBox <gi...@apache.org>]

HeartSaVioR edited a comment on issue #23854: [SPARK-22000][SQL] Inject necessary casts when data type of columns and matching type of fields are not equal
URL: https://github.com/apache/spark/pull/23854#issuecomment-466406523
 
 
   @maropu Thanks for the idea. I applied your suggestion, and also changed the title and description of PR.
   @srowen I just rolled back the change of JavaTypeInference, and confirmed new test passed without this.
   
   I couldn't inject Project(Exec) in `CatalystSerde.deserialize` since there's some case (`ExpressionEncoder.resolveAndBind()`) which doesn't use returned DeserializeToObject as LogicalPlan - it just leverages deserializer in DeserializeToObject which makes injected Project(Exec) no longer effective.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org