You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2013/11/13 18:07:17 UTC
Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method should
mark instance closed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-1889
https://issues.apache.org/jira/browse/ACCUMULO-1889
Repository: accumulo
Description
-------
ACCUMULO-1889 mark ZKI as closed once close() is called.
Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
Diffs
-----
src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
Diff: https://reviews.apache.org/r/15482/diff/
Testing
-------
unit tests pass, functional tests in progress.
Thanks,
Sean Busbey
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/#review28815
-----------------------------------------------------------
Ship it!
(non-binding) Looks right.
- Bill Havanki
On Nov. 13, 2013, 12:07 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15482/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 12:07 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1889
> https://issues.apache.org/jira/browse/ACCUMULO-1889
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-1889 mark ZKI as closed once close() is called.
>
> Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
>
>
> Diffs
> -----
>
> src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
>
> Diff: https://reviews.apache.org/r/15482/diff/
>
>
> Testing
> -------
>
> unit tests pass, functional tests in progress.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Bill Slacum <uj...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/#review28871
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Slacum
On Nov. 13, 2013, 9:35 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15482/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 9:35 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1889
> https://issues.apache.org/jira/browse/ACCUMULO-1889
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-1889 mark ZKI as closed once close() is called.
>
> Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
>
>
> Diffs
> -----
>
> src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
>
> Diff: https://reviews.apache.org/r/15482/diff/
>
>
> Testing
> -------
>
> unit tests pass, functional tests in progress.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/#review28930
-----------------------------------------------------------
Ship it!
Ship It!
- Christopher Tubbs
On Nov. 13, 2013, 4:35 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15482/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 4:35 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1889
> https://issues.apache.org/jira/browse/ACCUMULO-1889
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-1889 mark ZKI as closed once close() is called.
>
> Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
>
>
> Diffs
> -----
>
> src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
>
> Diff: https://reviews.apache.org/r/15482/diff/
>
>
> Testing
> -------
>
> unit tests pass, functional tests in progress.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Ryan Fishel <ry...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/#review28874
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Fishel
On Nov. 13, 2013, 9:35 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15482/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 9:35 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1889
> https://issues.apache.org/jira/browse/ACCUMULO-1889
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-1889 mark ZKI as closed once close() is called.
>
> Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
>
>
> Diffs
> -----
>
> src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
>
> Diff: https://reviews.apache.org/r/15482/diff/
>
>
> Testing
> -------
>
> unit tests pass, functional tests in progress.
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 9:35 p.m.)
Review request for accumulo.
Changes
-------
rolling back catch of AccumuloException, since the ZC and TU close methods don't throw it.
Bugs: ACCUMULO-1889
https://issues.apache.org/jira/browse/ACCUMULO-1889
Repository: accumulo
Description
-------
ACCUMULO-1889 mark ZKI as closed once close() is called.
Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
Diffs (updated)
-----
src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
Diff: https://reviews.apache.org/r/15482/diff/
Testing
-------
unit tests pass, functional tests in progress.
Thanks,
Sean Busbey
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 9:25 p.m.)
Review request for accumulo.
Changes
-------
update with feedback from Chris.
Bugs: ACCUMULO-1889
https://issues.apache.org/jira/browse/ACCUMULO-1889
Repository: accumulo
Description
-------
ACCUMULO-1889 mark ZKI as closed once close() is called.
Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
Diffs (updated)
-----
src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
Diff: https://reviews.apache.org/r/15482/diff/
Testing
-------
unit tests pass, functional tests in progress.
Thanks,
Sean Busbey
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 7:54 p.m.)
Review request for accumulo.
Bugs: ACCUMULO-1889
https://issues.apache.org/jira/browse/ACCUMULO-1889
Repository: accumulo
Description
-------
ACCUMULO-1889 mark ZKI as closed once close() is called.
Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
Diffs
-----
src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
Diff: https://reviews.apache.org/r/15482/diff/
Testing
-------
unit tests pass, functional tests in progress.
Thanks,
Sean Busbey
Re: Review Request 15482: ACCUMULO-1889 ZooKeeperInstance close method
should mark instance closed.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15482/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 5:07 p.m.)
Review request for accumulo.
Bugs: ACCUMULO-1889
https://issues.apache.org/jira/browse/ACCUMULO-1889
Repository: accumulo
Description
-------
ACCUMULO-1889 mark ZKI as closed once close() is called.
Once a given ZKI has .close() called, mark that instance closed regardless of outstanding client count.
Diffs
-----
src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e
Diff: https://reviews.apache.org/r/15482/diff/
Testing
-------
unit tests pass, functional tests in progress.
Thanks,
Sean Busbey