You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "snmvaughan (via GitHub)" <gi...@apache.org> on 2023/01/25 17:12:16 UTC
[GitHub] [spark] snmvaughan opened a new pull request, #39745: [SPARK-42188] Force SBT protobuf version to match Maven on branch 3.2
snmvaughan opened a new pull request, #39745:
URL: https://github.com/apache/spark/pull/39745
### What changes were proposed in this pull request?
Update `SparkBuild.scala` to force SBT use of `protobuf-java` to match the Maven version. The Maven dependencyManagement section forces `protobuf-java` to use `2.5.0`, but SBT is using `3.14.0`.
### Why are the changes needed?
Define `protoVersion` in `SparkBuild.scala` and use it in `DependencyOverrides` to force the SBT version of `protobuf-java` to match the setting defined in the Maven top-level `pom.xml`. Add comments to both `pom.xml` and `SparkBuild.scala` to ensure that the values are kept in sync.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Before the update, SBT reported using `3.14.0`:
```
% build/sbt dependencyTree | grep proto | sed 's/^.*-com/com/' | sort | uniq -c
8 com.google.protobuf:protobuf-java:2.5.0 (evicted by: 3.14.0)
70 com.google.protobuf:protobuf-java:3.14.0
```
After the patch is applied, SBT reports using `2.5.0`:
```
% build/sbt dependencyTree | grep proto | sed 's/^.*-com/com/' | sort | uniq -c
70 com.google.protobuf:protobuf-java:2.5.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] snmvaughan commented on pull request #39745: [SPARK-42188] Force SBT protobuf version to match Maven on branch 3.2
Posted by "snmvaughan (via GitHub)" <gi...@apache.org>.
snmvaughan commented on PR #39745:
URL: https://github.com/apache/spark/pull/39745#issuecomment-1403974170
> Thank you for making a PR, but we need to review this at `master`(Spark 3.5), `branch-3.4` (Spark 3.4), `branch-3.3` (Spark 3.3) first, @snmvaughan .
There is an already an equivalent change (with a different protobuf version) in `master` and `branch-3.4`. I'll submit another pull request for `branch-3.3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao closed pull request #39745: [SPARK-42188][BUILD][3.2] Force SBT protobuf version to match Maven
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao closed pull request #39745: [SPARK-42188][BUILD][3.2] Force SBT protobuf version to match Maven
URL: https://github.com/apache/spark/pull/39745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #39745: [SPARK-42188][BUILD][3.2] Force SBT protobuf version to match Maven
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #39745:
URL: https://github.com/apache/spark/pull/39745#issuecomment-1404488350
Merged to 3.2. Thanks @snmvaughan et al.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39745: [SPARK-42188] Force SBT protobuf version to match Maven on branch 3.2
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39745:
URL: https://github.com/apache/spark/pull/39745#issuecomment-1403985274
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #39745: [SPARK-42188] Force SBT protobuf version to match Maven on branch 3.2
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #39745:
URL: https://github.com/apache/spark/pull/39745#issuecomment-1404250420
cc @kazuyukitanimura
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org