[GitHub] [pinot] xiangfu0 commented on a change in pull request #8193: Enable service discovery in controller too

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #8193:
URL: https://github.com/apache/pinot/pull/8193#discussion_r804961034



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/api/ServiceAutoDiscoveryFeature.java
##########
@@ -68,8 +69,8 @@
  * pinot-integration-tests/src/main/java/org/apache/pinot/broker/integration/tests/BrokerTestAutoLoadedService.java
  * </code>
  */
-public class BrokerServiceAutoDiscoveryFeature implements Feature {
-    private static final Logger LOGGER = LoggerFactory.getLogger(BrokerServiceAutoDiscoveryFeature.class);
+public class ServiceAutoDiscoveryFeature implements Feature {

Review comment:
       What will happen if we have PinotServiceManager deploying controller/broker/server in the same JVM and all of them trying to load this `ServiceAutoDiscoveryFeature`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org