You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/05 22:18:15 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3277: Disable const-random ahash feature on non-WASM (#3271)
tustvold opened a new pull request, #3277:
URL: https://github.com/apache/arrow-rs/pull/3277
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3271
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Copy configuration from arrow crate to only enable compile-time-rng where necessary.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Fuuzetsu commented on pull request #3277: Disable const-random ahash feature on non-WASM (#3271)
Posted by GitBox <gi...@apache.org>.
Fuuzetsu commented on PR #3277:
URL: https://github.com/apache/arrow-rs/pull/3277#issuecomment-1338576102
@viirya @tustvold Did you check that this actually does anything? The way that cargo resolution works, this change has no impact:
https://github.com/rust-lang/cargo/issues/1197
https://github.com/tkaitchuck/aHash/issues/140
Even if you put a feature behind a `target` that we're not compiling for, it _will_ get included. Therefore as long as `ahash` is in the tree and `compile-time-rng` is specified for any of the targets, it `const-random` will be pulled in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3277: Disable const-random ahash feature on non-WASM (#3271)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3277:
URL: https://github.com/apache/arrow-rs/pull/3277#issuecomment-1339075077
```
$ cargo check --no-default-features --target wasm32-unknown-unknown
Compiling autocfg v1.1.0
Compiling crunchy v0.2.2
Compiling libc v0.2.138
Compiling tiny-keccak v2.0.2
Compiling proc-macro-hack v0.5.19
Compiling cfg-if v1.0.0
Compiling version_check v0.9.4
Compiling once_cell v1.16.0
Checking byteorder v1.4.3
Checking static_assertions v1.1.0
Checking integer-encoding v3.0.4
Checking hashbrown v0.13.1
Compiling paste v1.0.9
Checking bytes v1.3.0
Compiling seq-macro v0.3.1
Checking twox-hash v1.6.3
Compiling ahash v0.8.2
Compiling num-traits v0.2.15
Compiling num-integer v0.1.45
Compiling num-rational v0.4.1
Compiling num-iter v0.1.43
Compiling num-bigint v0.4.3
Compiling getrandom v0.2.8
Compiling const-random-macro v0.1.15
Checking const-random v0.1.15
Checking num-complex v0.4.2
Checking ordered-float v2.10.0
Checking thrift v0.17.0
Checking chrono v0.4.23
Checking num v0.4.0
Checking parquet v28.0.0 (/home/raphael/repos/external/arrow-rs/parquet)
Finished dev [unoptimized + debuginfo] target(s) in 3.34s
```
```
Compiling num-traits v0.2.15
Compiling num-integer v0.1.45
Checking cfg-if v1.0.0
Checking once_cell v1.16.0
Checking static_assertions v1.1.0
Checking byteorder v1.4.3
Checking integer-encoding v3.0.4
Checking bytes v1.3.0
Checking hashbrown v0.13.1
Compiling num-iter v0.1.43
Compiling num-rational v0.4.1
Compiling ahash v0.8.2
Compiling num-bigint v0.4.3
Checking libc v0.2.138
Checking twox-hash v1.6.3
Checking getrandom v0.2.8
Checking num-complex v0.4.2
Checking ordered-float v2.10.0
Checking thrift v0.17.0
Checking chrono v0.4.23
Checking num v0.4.0
Checking parquet v28.0.0 (/home/raphael/repos/external/arrow-rs/parquet)
Finished dev [unoptimized + debuginfo] target(s) in 2.71s
```
So on wasm it is pulling in `const-random` and on non wasm32 platform it is not. So it does appear to be working?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3277: Disable const-random ahash feature on non-WASM (#3271)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3277:
URL: https://github.com/apache/arrow-rs/pull/3277#issuecomment-1338287125
Benchmark runs are scheduled for baseline = 94d597edab1cb6dd0c84b94ab223ba89901ccfb6 and contender = 7b38cb8eae4f1ae6fb451bf288b1b4b6f0642858. 7b38cb8eae4f1ae6fb451bf288b1b4b6f0642858 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9afac8d2efd5407f8664a5cc82b1de5a...7bf3a6e3a4b54da4b019c758bf44505b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3bb706005c19485b97f90f1bc531b65a...8d69fa2d512642afa7c9ae3f0887289f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/422bdbfec1054eb2bd03cc73314a1bc6...c740b21ba0d54f40b741fb615fc94c59/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cac4ecc955624a8dac9b52af95ff81ab...0128c48e4a1740178e55828c787bd880/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3277: Disable const-random ahash feature on non-WASM (#3271)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3277:
URL: https://github.com/apache/arrow-rs/pull/3277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org