You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "delei (via GitHub)" <gi...@apache.org> on 2026/07/26 09:59:33 UTC
[PR] doc: upgrade website dependencies and CI [fesod]
delei opened a new pull request, #968:
URL: https://github.com/apache/fesod/pull/968
## Purpose of the pull request
Fix the vulnerabilities identified by Dependabot.
## What's changed?
- bump **Docusaurus** to `v3.10.2` and related dependencies
- update **Node.js** version requirement to `24.0`
- update the CI workflow for build the website and deploy documents
- update ci and `pnpm-lock.yaml`
- fixed the issue with the date values in the markdown
## Result
**pnpm audit**
> Please first comment out the `md-lint` scripts in the `package.json` file.
```shell
$ pnpm audit --registry https://registry.npmjs.org
No known vulnerabilities found
```
**markdownlint-cli2**
```shell
$ markdownlint-cli2 --config ./.markdownlint-cli2.jsonc "./**/*.md" "#node_modules"
markdownlint-cli2 v0.23.1 (markdownlint v0.41.1)
Finding: ./**/*.md !node_modules website/**/*.md !**/node_modules/** !**/target/** !**/dist/**
Linting: 123 files
Summary: 0 issues in 0 files
```
## Checklist
- [x] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/).
- [x] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] docs: upgrade website dependencies and CI [fesod]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #968:
URL: https://github.com/apache/fesod/pull/968#discussion_r3652274015
##########
.github/workflows/deploy-docs.yml:
##########
@@ -26,18 +26,18 @@ jobs:
if: github.repository == 'apache/fesod'
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v4
+ - uses: actions/checkout@v5
with:
fetch-depth: 0
- - uses: pnpm/action-setup@v4
+ - uses: pnpm/action-setup@v6
with:
- version: 10
+ version: 11
run_install: false
Review Comment:
`pnpm/action-setup` is configured with `version: 11`, but the repo declares `packageManager: pnpm@11.8.0` in `website/package.json`. Pinning to a floating major can cause CI to run a different pnpm minor than developers, which can affect lockfile compatibility. Prefer reading the version from `website/package.json` (or pin the exact version).
##########
.github/workflows/preview-docs.yml:
##########
@@ -26,16 +26,19 @@ jobs:
deploy-preview:
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v4
+ - name: Checkout code
+ uses: actions/checkout@v5
- - uses: pnpm/action-setup@v4
+ - name: Setup pnpm
+ uses: pnpm/action-setup@v6
with:
- version: 10
+ version: 11
run_install: false
Review Comment:
`pnpm/action-setup` is pinned to `version: 11`, while `website/package.json` declares `packageManager: pnpm@11.8.0`. Using a floating major in CI can lead to different pnpm minor versions than contributors use (and potentially lockfile/behavior drift). Consider sourcing the pnpm version from `website/package.json` instead.
##########
.github/workflows/ci-docs.yml:
##########
@@ -34,23 +34,23 @@ jobs:
uses: actions/checkout@v5
- name: Setup pnpm
- uses: pnpm/action-setup@v4
+ uses: pnpm/action-setup@v6
with:
- version: 10
+ version: 11
run_install: false
Review Comment:
CI installs pnpm `version: 11` (floating major) even though `website/package.json` pins `packageManager: pnpm@11.8.0`. To avoid pnpm minor-version drift between CI and local dev (and potential lockfile/behavior changes), source the pnpm version from `website/package.json`.
##########
.github/dependabot.yml:
##########
@@ -41,3 +41,24 @@ updates:
labels:
- "dependencies"
- "github actions"
+
+ - package-ecosystem: "npm"
+ directory: "/website"
+ schedule:
+ interval: "monthly"
+ labels:
+ - "dependencies"
+ - "npm"
+ groups:
+ docusaur:
+ patterns:
+ - "@docusaurus/core"
+ - "@docusaurus/plugin-client-redirects"
+ - "@docusaurus/preset-classic"
+ others:
+ patterns:
+ - "*"
+ cooldown:
+ semver-patch-days: 90
+ include:
+ - "*"
Review Comment:
`cooldown` is currently nested under `groups`, but Dependabot expects `cooldown` at the update-entry level (sibling of `groups`). As written, this will likely be treated as an invalid group and the cooldown won’t apply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] docs: upgrade website dependencies and CI [fesod]
Posted by "delei (via GitHub)" <gi...@apache.org>.
delei merged PR #968:
URL: https://github.com/apache/fesod/pull/968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org