You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/08 05:11:00 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #972: Fix the suffix of hocon config file

asdf2014 opened a new pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This PR fixes the suffix of HOCON config file for `seatunnel-flink-examples` module with `.conf` instead of `.config`, so that this HOCON config file can be recognized by HOCON format plugins.
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #972: Fix the suffix of hocon config file

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972#issuecomment-1007893877


   Hi, @garyelephant . Thanks a lot for your comment. But I'm afraid  I didn't catch you. This PR already has renamed the config file you mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #972: Fix the suffix of hocon config file

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972#issuecomment-1007893877


   Hi, @garyelephant . Thanks a lot for your comment. But I'm afraid  I didn't catch you. This PR already has renamed the config file you mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] garyelephant merged pull request #972: Fix the suffix of hocon config file

Posted by GitBox <gi...@apache.org>.
garyelephant merged pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] garyelephant commented on pull request #972: Fix the suffix of hocon config file

Posted by GitBox <gi...@apache.org>.
garyelephant commented on pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972#issuecomment-1007892967


   @asdf2014 please also rename seatunnel-examples/seatunnel-flink-examples/src/main/resources/examples/fake_to_console.config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] garyelephant merged pull request #972: Fix the suffix of hocon config file

Posted by GitBox <gi...@apache.org>.
garyelephant merged pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] garyelephant commented on pull request #972: Fix the suffix of hocon config file

Posted by GitBox <gi...@apache.org>.
garyelephant commented on pull request #972:
URL: https://github.com/apache/incubator-seatunnel/pull/972#issuecomment-1007892967


   @asdf2014 please also rename seatunnel-examples/seatunnel-flink-examples/src/main/resources/examples/fake_to_console.config


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org