You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/16 11:06:08 UTC

[GitHub] [cloudstack] ravening opened a new pull request #5460: Display ACL id for the private gateway

ravening opened a new pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460


   ### Description
   Display link for acl id which is associated
   with the private gateway
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial
   
   
   ### Screenshots (if appropriate):
   
   ![Screenshot 2021-09-16 at 13 05 46](https://user-images.githubusercontent.com/10645273/133601380-f348e041-aada-4077-b882-d330dd9bea21.png)
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921520812


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921248485


   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] nvazquez commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921248275


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921521574


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921507128


   > @davidjumani can you check or do you know if instead of aclid, acl name could be used?
   
   Yup it should work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921539656


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5460 (SL-JID-660)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921537654


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921482310


   @davidjumani can you check or do you know if instead of aclid, acl name could be used? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#discussion_r710784489



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -414,6 +414,18 @@
             <router-link :to="{ path: '/vpc/' + resource.vpcid }">{{ resource.vpcname || resource.vpcid }}</router-link>
           </div>
         </div>
+
+        <div class="resource-detail-item" v-if="resource.aclid">
+          <div class="resource-detail-item__label">{{ $t('label.acl') }}</div>

Review comment:
       no label.acl, please use label.aclid or label.aclname instead.
   
   ```
   ui/public/locales/en.json:"label.aclid": "ACL",
   ui/public/locales/en.json:"label.aclname": "ACL Name",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921523568


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5460 (SL-JID-657)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921526264


   @rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] davidjumani commented on a change in pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#discussion_r710757420



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -414,6 +414,18 @@
             <router-link :to="{ path: '/vpc/' + resource.vpcid }">{{ resource.vpcname || resource.vpcid }}</router-link>
           </div>
         </div>
+
+        <div class="resource-detail-item" v-if="resource.aclid">
+          <div class="resource-detail-item__label">{{ $t('label.acl.id') }}</div>
+          <div class="resource-detail-item__details">
+            <span v-if="images.acl">
+              <resource-icon :image="getImage(images.acl)" size="1x" style="margin-right: 5px"/>
+            </span>
+            <a-icon v-else type="deployment-unit" />
+            <router-link :to="{ path: '/acllist/' + resource.aclid }">{{ resource.aclid }}</router-link>

Review comment:
       ```suggestion
               <router-link :to="{ path: '/acllist/' + resource.aclid }">{{ resource.aclname }}</router-link>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#discussion_r710784489



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -414,6 +414,18 @@
             <router-link :to="{ path: '/vpc/' + resource.vpcid }">{{ resource.vpcname || resource.vpcid }}</router-link>
           </div>
         </div>
+
+        <div class="resource-detail-item" v-if="resource.aclid">
+          <div class="resource-detail-item__label">{{ $t('label.acl') }}</div>

Review comment:
       no label.acl, please label.aclid or label.aclname instead.
   
   ```
   ui/public/locales/en.json:"label.aclid": "ACL",
   ui/public/locales/en.json:"label.aclname": "ACL Name",
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921521215


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921528362


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5460 (SL-JID-658)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921251042


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5460 (SL-JID-654)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921536739


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#issuecomment-921525749


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #5460: Display ACL id for the private gateway

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5460:
URL: https://github.com/apache/cloudstack/pull/5460#discussion_r710027407



##########
File path: ui/src/components/view/InfoCard.vue
##########
@@ -414,6 +414,18 @@
             <router-link :to="{ path: '/vpc/' + resource.vpcid }">{{ resource.vpcname || resource.vpcid }}</router-link>
           </div>
         </div>
+
+        <div class="resource-detail-item" v-if="resource.aclid">
+          <div class="resource-detail-item__label">{{ $t('label.acl.id') }}</div>
+          <div class="resource-detail-item__details">
+            <span v-if="images.acl">
+              <resource-icon :image="getImage(images.acl)" size="1x" style="margin-right: 5px"/>
+            </span>
+            <a-icon v-else type="deployment-unit" />
+            <router-link :to="{ path: '/acllist/' + resource.aclid }">{{ resource.aclid }}</router-link>

Review comment:
       Do ACL list have names, can we use that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org