You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 00:46:52 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request
#9009: [perf_logging] Add is_cached status when chart has error
graceguo-supercat opened a new pull request #9009: [perf_logging] Add is_cached status when chart has error
URL: https://github.com/apache/incubator-superset/pull/9009
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
when user load dashboard, if query returns 0 row, we will show `no data` and response 400. Superset front-end treat it as error. But the result will still be cached.
In front-end logging, we don't log is_cached status when chart has error. this may cause our cache rate not accurate. This PR is trying to fix this case (chart has error, and may also has is_cached status).
### TEST PLAN
manual test
### REVIEWERS
@etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9009:
[perf_logging] Add is_cached status when chart has error
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9009: [perf_logging] Add is_cached status when chart has error
URL: https://github.com/apache/incubator-superset/pull/9009#issuecomment-577949568
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=h1) Report
> Merging [#9009](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d3d860362044bd79d7331f0d66c5ae1112c0cbd7?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9009/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9009 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11682 11682
Branches 2864 2864
=======================================
Hits 6910 6910
Misses 4593 4593
Partials 179 179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/9009/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `47.94% <100%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=footer). Last update [d3d8603...690f7cb](https://codecov.io/gh/apache/incubator-superset/pull/9009?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat merged pull request #9009:
[perf_logging] Add is_cached status when chart has error
Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #9009: [perf_logging] Add is_cached status when chart has error
URL: https://github.com/apache/incubator-superset/pull/9009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org